Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2302443002: Revert of All DCP manager tests that enroll/register are tested with all auths. (Closed)

Created:
4 years, 3 months ago by battre
Modified:
4 years, 3 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, dkalin1, minz_google.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of All DCP manager tests that enroll/register are tested with all auths. (patchset #7 id:120001 of https://codereview.chromium.org/2287343004/ ) Reason for revert: Reverting due to use after free. See http://crbug.com/624187#c28 Original issue's description: > All DCP manager tests that enroll/register are tested with all auths. > > Use a FakeSigningService in the DeviceCloudPolicyInitializer in order > to be able to unit test re-enrollment for locked devices when > registering with a certificate. > > BUG=624187, 641447 > TEST=unit_tests > > Committed: https://crrev.com/f71058accb8d57221145dfb2c34769244d6cc54d > Cr-Commit-Position: refs/heads/master@{#415574} TBR=pastarmovj@chromium.org,drcrash@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624187, 641447 Committed: https://crrev.com/06c696c25462d6d7bfab67e3220387e3fa1faa67 Cr-Commit-Position: refs/heads/master@{#415612}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
battre
Created Revert of All DCP manager tests that enroll/register are tested with all auths.
4 years, 3 months ago (2016-08-31 11:46:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302443002/1
4 years, 3 months ago (2016-08-31 11:47:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 11:48:06 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 11:50:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06c696c25462d6d7bfab67e3220387e3fa1faa67
Cr-Commit-Position: refs/heads/master@{#415612}

Powered by Google App Engine
This is Rietveld 408576698