Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2302433002: [NoStatePrefetch] Track redirects in UMA (Closed)
Patch Set: review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_resource_throttle.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 99f4d0c0c02f73bca653c94e5060c31dd6169973..29c81db1af0ad8fcf040b068def8ec30f5632c4d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -45401,14 +45401,35 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="Prerender.NoStatePrefetchResourceTypes"
Alexei Svitkine (slow) 2016/09/06 19:50:23 Instead of deleting the previous metric, please ma
droger 2016/09/06 20:43:51 This metric is actually very recent (not even land
Alexei Svitkine (slow) 2016/09/06 21:50:52 Okay, if it was never logged, then I'm fine with t
- enum="NoStatePrefetchResourceType">
+<histogram name="Prerender.NoStatePrefetchMainResourceRedirects">
Alexei Svitkine (slow) 2016/09/06 21:50:52 Please add units="" e.g. units="redirects"
<owner>droger@chromium.org</owner>
<owner>mattcary@chromium.org</owner>
<owner>pasko@chromium.org</owner>
<summary>
- Type of resources loaded by NoStatePrefetch, distinguishing cacheable
+ Length of the redirect chain for main resources loaded by NoStatePrefetch.
+ Recorded when the final response in the chain is received.
+ </summary>
+</histogram>
+
+<histogram name="Prerender.NoStatePrefetchResponseTypes"
+ enum="NoStatePrefetchResponseType">
+ <owner>droger@chromium.org</owner>
+ <owner>mattcary@chromium.org</owner>
+ <owner>pasko@chromium.org</owner>
+ <summary>
+ Type of responses received by NoStatePrefetch, distinguishing cacheable
resources from no-store resources, and main resources from sub-resources.
+ Recorded when a response is received, including on each redirect.
+ </summary>
+</histogram>
+
+<histogram name="Prerender.NoStatePrefetchSubResourceRedirects">
Alexei Svitkine (slow) 2016/09/06 21:50:52 Ditto.
+ <owner>droger@chromium.org</owner>
+ <owner>mattcary@chromium.org</owner>
+ <owner>pasko@chromium.org</owner>
+ <summary>
+ Length of the redirect chain for sub-resources loaded by NoStatePrefetch.
+ Recorded when the final response in the chain is received.
</summary>
</histogram>
@@ -88287,11 +88308,15 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="1" label="Timed out"/>
</enum>
-<enum name="NoStatePrefetchResourceType" type="int">
- <int value="0" label="Main resource, cacheable"/>
- <int value="1" label="Main resource, no-store"/>
- <int value="2" label="Sub-resource, cacheable"/>
- <int value="3" label="Sub-resource, no-store"/>
+<enum name="NoStatePrefetchResponseType" type="int">
+ <int value="0" label="Sub-resource, cacheable"/>
+ <int value="1" label="Sub-resource, no-store"/>
+ <int value="2" label="Sub-resource redirect, cacheable"/>
+ <int value="3" label="Sub-resource redirect, no-store"/>
+ <int value="4" label="Main resource, cacheable"/>
+ <int value="5" label="Main resource, no-store"/>
+ <int value="6" label="Main resource redirect, cacheable"/>
+ <int value="7" label="Main resource redirect, no-store"/>
</enum>
<enum name="NotificationActionType" type="int">
@@ -103718,7 +103743,9 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Prerender.LocalPredictorTimeUntilUsed"/>
<affected-histogram name="Prerender.NetworkBytesUsed"/>
<affected-histogram name="Prerender.NetworkBytesWasted"/>
- <affected-histogram name="Prerender.NoStatePrefetchResourceTypes"/>
+ <affected-histogram name="Prerender.NoStatePrefetchMainResourceRedirects"/>
+ <affected-histogram name="Prerender.NoStatePrefetchResponseTypes"/>
+ <affected-histogram name="Prerender.NoStatePrefetchSubResourceRedirects"/>
<affected-histogram name="Prerender.PageVisitedStatus"/>
<affected-histogram name="Prerender.PerceivedPLT"/>
<affected-histogram name="Prerender.PerceivedPLTFirstAfterMiss"/>
« no previous file with comments | « chrome/browser/prerender/prerender_resource_throttle.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698