Chromium Code Reviews Chromium Code Reviews
Issue 2302433002:
[NoStatePrefetch] Track redirects in UMA (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 99f4d0c0c02f73bca653c94e5060c31dd6169973..9a513a6a5b3bccadc56a92e84d1f3a571735ab92 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -45401,8 +45401,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| -<histogram name="Prerender.NoStatePrefetchResourceTypes" |
| - enum="NoStatePrefetchResourceType"> |
| +<histogram name="Prerender.NoStatePrefetchMainResourceRedirects"> |
| + <owner>droger@chromium.org</owner> |
| + <owner>mattcary@chromium.org</owner> |
| + <owner>pasko@chromium.org</owner> |
| + <summary> |
| + Length of the redirect chain for main resources loaded by NoStatePrefetch. |
|
pasko
2016/09/05 14:39:48
We should specify: "Recorded when the final respon
droger
2016/09/05 15:03:44
Done.
|
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Prerender.NoStatePrefetchResponseTypes" |
| + enum="NoStatePrefetchResponseType"> |
| <owner>droger@chromium.org</owner> |
| <owner>mattcary@chromium.org</owner> |
| <owner>pasko@chromium.org</owner> |
| @@ -45412,6 +45421,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="Prerender.NoStatePrefetchSubResourceRedirects"> |
| + <owner>droger@chromium.org</owner> |
| + <owner>mattcary@chromium.org</owner> |
| + <owner>pasko@chromium.org</owner> |
| + <summary> |
| + Length of the redirect chain for sub-resources loaded by NoStatePrefetch. |
|
pasko
2016/09/05 14:39:48
Please mention the time of recording here as well.
droger
2016/09/05 15:03:44
Done.
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Prerender.OmniboxNavigationsCouldPrerender"> |
| <owner>pasko@chromium.org</owner> |
| <summary> |
| @@ -88287,11 +88305,15 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="1" label="Timed out"/> |
| </enum> |
| -<enum name="NoStatePrefetchResourceType" type="int"> |
| - <int value="0" label="Main resource, cacheable"/> |
| - <int value="1" label="Main resource, no-store"/> |
| - <int value="2" label="Sub-resource, cacheable"/> |
| - <int value="3" label="Sub-resource, no-store"/> |
| +<enum name="NoStatePrefetchResponseType" type="int"> |
| + <int value="0" label="Sub-resource, cacheable"/> |
| + <int value="1" label="Sub-resource, no-store"/> |
| + <int value="2" label="Sub-resource redirect, cacheable"/> |
| + <int value="3" label="Sub-resource redirect, no-store"/> |
| + <int value="4" label="Main resource, cacheable"/> |
| + <int value="5" label="Main resource, no-store"/> |
| + <int value="6" label="Main resource redirect, cacheable"/> |
| + <int value="7" label="Main resource redirect, no-store"/> |
| </enum> |
| <enum name="NotificationActionType" type="int"> |
| @@ -103718,7 +103740,9 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <affected-histogram name="Prerender.LocalPredictorTimeUntilUsed"/> |
| <affected-histogram name="Prerender.NetworkBytesUsed"/> |
| <affected-histogram name="Prerender.NetworkBytesWasted"/> |
| - <affected-histogram name="Prerender.NoStatePrefetchResourceTypes"/> |
| + <affected-histogram name="Prerender.NoStatePrefetchMainResourceRedirects"/> |
| + <affected-histogram name="Prerender.NoStatePrefetchResponseTypes"/> |
| + <affected-histogram name="Prerender.NoStatePrefetchSubResourceRedirects"/> |
| <affected-histogram name="Prerender.PageVisitedStatus"/> |
| <affected-histogram name="Prerender.PerceivedPLT"/> |
| <affected-histogram name="Prerender.PerceivedPLTFirstAfterMiss"/> |
