Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2302423003: [Offline pages] Ensure that download notifications are updated after restart of Chrome (Closed)

Created:
4 years, 3 months ago by fgorski
Modified:
4 years, 3 months ago
Reviewers:
qinmin
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Ensure that download notifications are updated after restart of Chrome * This patch removes checks for DownloadManagementService to be initialized, as it might not have been right after a restart of Chrome. BUG=641590 R=qinmin@chromium.org Committed: https://crrev.com/bae90340ad5e6a7aabe02213d7237c77a1ca6a1d Cr-Commit-Position: refs/heads/master@{#416366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
fgorski
PTAL
4 years, 3 months ago (2016-09-02 21:44:19 UTC) #2
qinmin
lgtm
4 years, 3 months ago (2016-09-02 21:45:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302423003/1
4 years, 3 months ago (2016-09-02 21:46:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 22:22:40 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 22:25:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bae90340ad5e6a7aabe02213d7237c77a1ca6a1d
Cr-Commit-Position: refs/heads/master@{#416366}

Powered by Google App Engine
This is Rietveld 408576698