Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2302373003: [Android] Delete the logcat file after appending it to the minidump. (Closed)

Created:
4 years, 3 months ago by Ilya Sherman
Modified:
4 years, 3 months ago
Reviewers:
acleung1, Maria
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org, gayane -on leave until 09-2017
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Delete the logcat file after appending it to the minidump. BUG=643878 TEST=none R=acleung@chromium.org Committed: https://crrev.com/d3d6454cbe7a09c3c2c79f31ae40af6742b08c62 Cr-Commit-Position: refs/heads/master@{#417013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationCallable.java View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Ilya Sherman
Hi Alan, PTAL. The design doc that you sent me indicated that the logcat file ...
4 years, 3 months ago (2016-09-03 00:49:43 UTC) #1
acleung1
lgtm.
4 years, 3 months ago (2016-09-03 05:30:01 UTC) #2
Ilya Sherman
Maria, could you PTAL for OWNERS approval?
4 years, 3 months ago (2016-09-06 23:41:25 UTC) #4
Maria
lgtm
4 years, 3 months ago (2016-09-07 04:12:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302373003/1
4 years, 3 months ago (2016-09-07 18:07:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 18:54:39 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 18:57:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3d6454cbe7a09c3c2c79f31ae40af6742b08c62
Cr-Commit-Position: refs/heads/master@{#417013}

Powered by Google App Engine
This is Rietveld 408576698