Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: pkg/compiler/lib/src/enqueue.dart

Issue 2302363003: No longer store the compilation-context in WorkItem. (Closed)
Patch Set: ... lint Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/enqueue.dart
diff --git a/pkg/compiler/lib/src/enqueue.dart b/pkg/compiler/lib/src/enqueue.dart
index 56c6a6c28f3712efb0c29f986d48fd6335feb720..06b967035143a7b574d677f9ba77e20764c38df8 100644
--- a/pkg/compiler/lib/src/enqueue.dart
+++ b/pkg/compiler/lib/src/enqueue.dart
@@ -10,7 +10,7 @@ import 'common/names.dart' show Identifiers;
import 'common/resolution.dart' show Resolution;
import 'common/resolution.dart' show ResolutionWorkItem;
import 'common/tasks.dart' show CompilerTask;
-import 'common/work.dart' show ItemCompilationContext, WorkItem;
+import 'common/work.dart' show WorkItem;
import 'common.dart';
import 'compiler.dart' show Compiler;
import 'dart_types.dart' show DartType, InterfaceType;
@@ -39,8 +39,6 @@ import 'universe/world_impact.dart'
show ImpactUseCase, WorldImpact, WorldImpactVisitor;
import 'util/util.dart' show Setlet;
-typedef ItemCompilationContext ItemCompilationContextCreator();
-
class EnqueueTask extends CompilerTask {
final ResolutionEnqueuer resolution;
final Enqueuer codegen;
@@ -52,7 +50,6 @@ class EnqueueTask extends CompilerTask {
: compiler = compiler,
resolution = new ResolutionEnqueuer(
compiler,
- compiler.backend.createItemCompilationContext,
compiler.options.analyzeOnly && compiler.options.analyzeMain
? const EnqueuerStrategy()
: const TreeShakingEnqueuerStrategy()),
@@ -128,7 +125,6 @@ class ResolutionEnqueuer extends Enqueuer {
final String name;
final Compiler compiler; // TODO(ahe): Remove this dependency.
final EnqueuerStrategy strategy;
- final ItemCompilationContextCreator itemCompilationContextCreator;
final Map<String, Set<Element>> instanceMembersByName =
new Map<String, Set<Element>>();
final Map<String, Set<Element>> instanceFunctionsByName =
@@ -147,8 +143,7 @@ class ResolutionEnqueuer extends Enqueuer {
WorldImpactVisitor impactVisitor;
- ResolutionEnqueuer(
- Compiler compiler, this.itemCompilationContextCreator, this.strategy)
+ ResolutionEnqueuer(Compiler compiler, this.strategy)
: this.name = 'resolution enqueuer',
this.compiler = compiler,
processedElements = new Set<AstElement>(),
@@ -740,8 +735,7 @@ class ResolutionEnqueuer extends Enqueuer {
compiler.world.registerUsedElement(element);
- ResolutionWorkItem workItem = compiler.resolution
- .createWorkItem(element, itemCompilationContextCreator());
+ ResolutionWorkItem workItem = compiler.resolution.createWorkItem(element);
queue.add(workItem);
// Enable isolate support if we start using something from the isolate
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698