Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: pkg/compiler/lib/src/common/codegen.dart

Issue 2302363003: No longer store the compilation-context in WorkItem. (Closed)
Patch Set: ... lint Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/common/backend_api.dart ('k') | pkg/compiler/lib/src/common/resolution.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/common/codegen.dart
diff --git a/pkg/compiler/lib/src/common/codegen.dart b/pkg/compiler/lib/src/common/codegen.dart
index 760fd5e6d2b724365b26c8f3918b2fc3ef32d6dd..84eb4222d70511e2e73b6c6a618c9d573ef4238f 100644
--- a/pkg/compiler/lib/src/common/codegen.dart
+++ b/pkg/compiler/lib/src/common/codegen.dart
@@ -22,7 +22,7 @@ import '../universe/world_impact.dart'
show WorldImpact, WorldImpactBuilder, WorldImpactVisitor;
import '../util/util.dart' show Pair, Setlet;
import 'registry.dart' show Registry, EagerRegistry;
-import 'work.dart' show ItemCompilationContext, WorkItem;
+import 'work.dart' show WorkItem;
class CodegenImpact extends WorldImpact {
const CodegenImpact();
@@ -227,8 +227,7 @@ class CodegenWorkItem extends WorkItem {
CodegenRegistry registry;
final ResolvedAst resolvedAst;
- factory CodegenWorkItem(Compiler compiler, AstElement element,
- ItemCompilationContext compilationContext) {
+ factory CodegenWorkItem(Compiler compiler, AstElement element) {
// If this assertion fails, the resolution callbacks of the backend may be
// missing call of form registry.registerXXX. Alternatively, the code
// generation could spuriously be adding dependencies on things we know we
@@ -236,13 +235,12 @@ class CodegenWorkItem extends WorkItem {
assert(invariant(element, element.hasResolvedAst,
message: "$element has no resolved ast."));
ResolvedAst resolvedAst = element.resolvedAst;
- return new CodegenWorkItem.internal(resolvedAst, compilationContext);
+ return new CodegenWorkItem.internal(resolvedAst);
}
- CodegenWorkItem.internal(
- ResolvedAst resolvedAst, ItemCompilationContext compilationContext)
+ CodegenWorkItem.internal(ResolvedAst resolvedAst)
: this.resolvedAst = resolvedAst,
- super(resolvedAst.element, compilationContext);
+ super(resolvedAst.element);
WorldImpact run(Compiler compiler, Enqueuer world) {
if (world.isProcessed(element)) return const WorldImpact();
« no previous file with comments | « pkg/compiler/lib/src/common/backend_api.dart ('k') | pkg/compiler/lib/src/common/resolution.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698