Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: pkg/compiler/lib/src/js_backend/enqueuer.dart

Issue 2302363003: No longer store the compilation-context in WorkItem. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/enqueuer.dart
diff --git a/pkg/compiler/lib/src/js_backend/enqueuer.dart b/pkg/compiler/lib/src/js_backend/enqueuer.dart
index ba7f2d24e81e5ff5c675a1ad30514e89ff76dee0..d95c529c0948a3b43cd3d2183e4a7d0558e63894 100644
--- a/pkg/compiler/lib/src/js_backend/enqueuer.dart
+++ b/pkg/compiler/lib/src/js_backend/enqueuer.dart
@@ -44,7 +44,6 @@ class CodegenEnqueuer implements Enqueuer {
final String name;
final Compiler compiler; // TODO(ahe): Remove this dependency.
final EnqueuerStrategy strategy;
- final ItemCompilationContextCreator itemCompilationContextCreator;
final Map<String, Set<Element>> instanceMembersByName =
new Map<String, Set<Element>>();
final Map<String, Set<Element>> instanceFunctionsByName =
@@ -65,8 +64,7 @@ class CodegenEnqueuer implements Enqueuer {
WorldImpactVisitor impactVisitor;
- CodegenEnqueuer(
- Compiler compiler, this.itemCompilationContextCreator, this.strategy)
+ CodegenEnqueuer(Compiler compiler, this.strategy)
: queue = new Queue<CodegenWorkItem>(),
newlyEnqueuedElements = compiler.cacheStrategy.newSet(),
newlySeenSelectors = compiler.cacheStrategy.newSet(),
@@ -672,9 +670,7 @@ class CodegenEnqueuer implements Enqueuer {
throw new SpannableAssertionFailure(
element, "Codegen work list is closed. Trying to add $element");
}
- CodegenWorkItem workItem =
- new CodegenWorkItem(compiler, element, itemCompilationContextCreator());
- queue.add(workItem);
+ queue.add(new CodegenWorkItem(compiler, element));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698