Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Side by Side Diff: pkg/compiler/lib/src/ssa/ssa.dart

Issue 2302363003: No longer store the compilation-context in WorkItem. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library ssa; 5 library ssa;
6 6
7 import '../common/codegen.dart' show CodegenWorkItem; 7 import '../common/codegen.dart' show CodegenWorkItem;
8 import '../common/tasks.dart' show CompilerTask; 8 import '../common/tasks.dart' show CompilerTask;
9 import '../elements/elements.dart' show Element, FunctionElement; 9 import '../elements/elements.dart' show Element, FunctionElement;
10 import '../io/source_information.dart'; 10 import '../io/source_information.dart';
11 import '../js/js.dart' as js; 11 import '../js/js.dart' as js;
12 import '../js_backend/backend.dart' show JavaScriptBackend, FunctionCompiler; 12 import '../js_backend/backend.dart' show JavaScriptBackend, FunctionCompiler;
13 13
14 import 'builder.dart'; 14 import 'builder.dart';
15 import 'builder_kernel.dart'; 15 import 'builder_kernel.dart';
16 import 'codegen.dart'; 16 import 'codegen.dart';
17 import 'context.dart';
17 import 'nodes.dart'; 18 import 'nodes.dart';
18 import 'optimize.dart'; 19 import 'optimize.dart';
19 20
20 class SsaFunctionCompiler implements FunctionCompiler { 21 class SsaFunctionCompiler implements FunctionCompiler {
21 final SsaCodeGeneratorTask generator; 22 final SsaCodeGeneratorTask generator;
22 final SsaBuilderTask builder; 23 final SsaBuilderTask builder;
23 final SsaKernelBuilderTask builderKernel; 24 final SsaKernelBuilderTask builderKernel;
24 final SsaOptimizerTask optimizer; 25 final SsaOptimizerTask optimizer;
25 final JavaScriptBackend backend; 26 final JavaScriptBackend backend;
26 final bool useKernel; 27 final bool useKernel;
27 28
28 SsaFunctionCompiler(JavaScriptBackend backend, 29 SsaFunctionCompiler(JavaScriptBackend backend,
29 SourceInformationStrategy sourceInformationFactory, this.useKernel) 30 SourceInformationStrategy sourceInformationFactory, this.useKernel)
30 : generator = new SsaCodeGeneratorTask(backend, sourceInformationFactory), 31 : generator = new SsaCodeGeneratorTask(backend, sourceInformationFactory),
31 builder = new SsaBuilderTask(backend, sourceInformationFactory), 32 builder = new SsaBuilderTask(backend, sourceInformationFactory),
32 builderKernel = 33 builderKernel =
33 new SsaKernelBuilderTask(backend, sourceInformationFactory), 34 new SsaKernelBuilderTask(backend, sourceInformationFactory),
34 optimizer = new SsaOptimizerTask(backend), 35 optimizer = new SsaOptimizerTask(backend),
35 backend = backend; 36 backend = backend;
36 37
37 /// Generates JavaScript code for `work.element`. 38 /// Generates JavaScript code for `work.element`.
38 /// Using the ssa builder, optimizer and codegenerator. 39 /// Using the ssa builder, optimizer and codegenerator.
39 js.Fun compile(CodegenWorkItem work) { 40 js.Fun compile(CodegenWorkItem work) {
40 HGraph graph = useKernel ? builderKernel.build(work) : builder.build(work); 41 var context = new SsaCompilationContext();
41 optimizer.optimize(work, graph); 42 HGraph graph = useKernel
43 ? builderKernel.build(work, context)
44 : builder.build(work, context);
45 optimizer.optimize(graph, work, context);
42 Element element = work.element; 46 Element element = work.element;
43 js.Expression result = generator.generateCode(work, graph); 47 js.Expression result = generator.generateCode(work, graph);
44 if (element is FunctionElement) { 48 if (element is FunctionElement) {
45 // TODO(sigmund): replace by kernel transformer when `useKernel` is true. 49 // TODO(sigmund): replace by kernel transformer when `useKernel` is true.
46 result = backend.rewriteAsync(element, result); 50 result = backend.rewriteAsync(element, result);
47 } 51 }
48 return result; 52 return result;
49 } 53 }
50 54
51 Iterable<CompilerTask> get tasks { 55 Iterable<CompilerTask> get tasks {
52 return <CompilerTask>[ 56 return <CompilerTask>[
53 useKernel ? builderKernel : builder, 57 useKernel ? builderKernel : builder,
54 optimizer, 58 optimizer,
55 generator 59 generator
56 ]; 60 ];
57 } 61 }
58 } 62 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698