Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2302363002: Revert of Add test of MakeUniqueID() and friends. (Closed)

Created:
4 years, 3 months ago by Marc Treib
Modified:
4 years, 3 months ago
Reviewers:
sfiera
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add test of MakeUniqueID() and friends. (patchset #3 id:40001 of https://codereview.chromium.org/2306043002/ ) Reason for revert: Fails on several bots: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQAsSCVdmQ3VscHJpdCIxY2hyb21pdW0vY2MyZjYxMjA0YzBlZGU1YzNjNTY5OWJjMDc5NmJiMmJiZmFiNzI1OQw Original issue's description: > Add test of MakeUniqueID() and friends. > > Committed: https://crrev.com/cc2f61204c0ede5c3c5699bc0796bb2bbfab7259 > Cr-Commit-Position: refs/heads/master@{#416259} TBR=sfiera@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/f329cf691a20ceb09ae5846adeb01006e2aa80a8 Cr-Commit-Position: refs/heads/master@{#416268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -118 lines) Patch
M components/ntp_snippets/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/ntp_snippets/content_suggestions_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
D components/ntp_snippets/content_suggestions_provider_unittest.cc View 1 chunk +0 lines, -115 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Marc Treib
Created Revert of Add test of MakeUniqueID() and friends.
4 years, 3 months ago (2016-09-02 15:30:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302363002/1
4 years, 3 months ago (2016-09-02 15:31:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 15:32:11 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 15:33:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f329cf691a20ceb09ae5846adeb01006e2aa80a8
Cr-Commit-Position: refs/heads/master@{#416268}

Powered by Google App Engine
This is Rietveld 408576698