Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2302353003: [Android] Add configurations for cronet continuous builder + trybot. (Closed)

Created:
4 years, 3 months ago by jbudorick
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add configurations for cronet continuous builder + trybot. BUG=634350 Committed: https://crrev.com/64e96a0f101d325646f3759b676dc422612c7fd8 Cr-Commit-Position: refs/heads/master@{#416989}

Patch Set 1 #

Total comments: 4

Patch Set 2 : xunjieli comments #

Total comments: 2

Patch Set 3 : dpranke comments #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M testing/buildbot/chromium.android.json View 1 1 chunk +2 lines, -8 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 2 6 chunks +18 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
jbudorick
4 years, 3 months ago (2016-09-02 18:05:50 UTC) #2
xunjieli
https://codereview.chromium.org/2302353003/diff/1/testing/buildbot/chromium.android.json File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/2302353003/diff/1/testing/buildbot/chromium.android.json#newcode4 testing/buildbot/chromium.android.json:4: "cronet" Can we compile "cronet_package" target? which will compile ...
4 years, 3 months ago (2016-09-02 18:21:03 UTC) #3
jbudorick
https://codereview.chromium.org/2302353003/diff/1/testing/buildbot/chromium.android.json File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/2302353003/diff/1/testing/buildbot/chromium.android.json#newcode4 testing/buildbot/chromium.android.json:4: "cronet" On 2016/09/02 18:21:02, xunjieli wrote: > Can we ...
4 years, 3 months ago (2016-09-02 18:27:19 UTC) #4
xunjieli
lgtm! Thanks a lot for adding the CQ support!
4 years, 3 months ago (2016-09-02 18:30:37 UTC) #5
ghost stip (do not use)
lgtm
4 years, 3 months ago (2016-09-02 18:32:07 UTC) #6
jbudorick
+dpranke for owners
4 years, 3 months ago (2016-09-02 18:32:42 UTC) #8
jbudorick
On 2016/09/02 18:32:42, jbudorick wrote: > +dpranke for owners (tools/mb/ owners, that is)
4 years, 3 months ago (2016-09-02 18:32:56 UTC) #9
Dirk Pranke
https://codereview.chromium.org/2302353003/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2302353003/diff/20001/tools/mb/mb_config.pyl#newcode1105 tools/mb/mb_config.pyl:1105: 'android', 'cronet', 'gn', 'release_trybot', 'arm_no_neon' This should have 'arm_no_neon' ...
4 years, 3 months ago (2016-09-02 20:24:52 UTC) #10
jbudorick
https://codereview.chromium.org/2302353003/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2302353003/diff/20001/tools/mb/mb_config.pyl#newcode1105 tools/mb/mb_config.pyl:1105: 'android', 'cronet', 'gn', 'release_trybot', 'arm_no_neon' On 2016/09/02 20:24:52, Dirk ...
4 years, 3 months ago (2016-09-02 22:46:18 UTC) #11
Dirk Pranke
lgtm, thanks.
4 years, 3 months ago (2016-09-06 01:01:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302353003/60001
4 years, 3 months ago (2016-09-07 15:56:44 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-07 17:50:00 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 17:52:32 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/64e96a0f101d325646f3759b676dc422612c7fd8
Cr-Commit-Position: refs/heads/master@{#416989}

Powered by Google App Engine
This is Rietveld 408576698