Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2302343002: PPC/s390: [Interpreter] Collect type feedback for 'new' in the bytecode handler (Closed)

Created:
4 years, 3 months ago by JaideepBajwa
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [Interpreter] Collect type feedback for 'new' in the bytecode handler Port 7e5b8feed307288d602c11cb4fb1184cbbc21d5a Original commit message: Collect type feedback in the bytecode handler for 'new' bytecode. The earlier cl (https://codereview.chromium.org/2153433002/) was reverted because that implementation did not collect allocation site feedback. This regressed delta blue by an order of magnitude. This implementation includes collection of allocation site feedback. Reland of https://codereview.chromium.org/2190293003/ with a bug fix. R=mythria@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280, v8:4780 LOG=N Committed: https://crrev.com/1d2ab6e0bd520087902ebdea68466f175add2468 Cr-Commit-Position: refs/heads/master@{#39138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -12 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 3 chunks +23 lines, -5 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 2 chunks +22 lines, -5 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 3 months ago (2016-09-02 14:27:10 UTC) #1
john.yan
lgtm
4 years, 3 months ago (2016-09-02 14:28:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302343002/1
4 years, 3 months ago (2016-09-02 14:29:38 UTC) #4
mythria
lgtm.
4 years, 3 months ago (2016-09-02 14:41:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 14:55:05 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 14:55:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d2ab6e0bd520087902ebdea68466f175add2468
Cr-Commit-Position: refs/heads/master@{#39138}

Powered by Google App Engine
This is Rietveld 408576698