Small perf optimizations preparing sampled images in vulkan

Small perf optimizations preparing sampled images in vulkan

In our current setup, there is no need for storing the sampled images in an
array and then putting in barriers for them later. If we ever change the
system to building up these secondary command buffers early, we will need
to go back to storing the sampled images.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302333002

Committed: https://skia.googlesource.com/skia/+/8d2141f0dbb36b92d0e3feb23a08663c29b59db0

[egdaniel, 2016-09-02 14:06:27]

Description was changed from

==========
Small perf optimizations preparing sampled images in vulkan

In our current setup, there is no need for storing the sampled images in an
array and then putting in barriers for them later. If we ever change the
system to building up these secondary command buffers early, we will need
to go back to storing the sampled images.

BUG=skia:
==========

to

==========
Small perf optimizations preparing sampled images in vulkan

In our current setup, there is no need for storing the sampled images in an
array and then putting in barriers for them later. If we ever change the
system to building up these secondary command buffers early, we will need
to go back to storing the sampled images.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302333002
==========

[egdaniel, 2016-09-02 14:08:25]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com

[egdaniel, 2016-09-02 14:26:05]

The CQ bit was checked by egdaniel@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 14:26:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jvanverth1, 2016-09-02 14:37:27]

lgtm

https://codereview.chromium.org/2302333002/diff/20001/src/gpu/vk/GrVkGpuComma...
File src/gpu/vk/GrVkGpuCommandBuffer.cpp (right):

https://codereview.chromium.org/2302333002/diff/20001/src/gpu/vk/GrVkGpuComma...
src/gpu/vk/GrVkGpuCommandBuffer.cpp:357: // If we ever decide to create the
secondary command buffers ahead of time before we are
Add a TODO: before this? At first glance it looks like it's commenting on what's
currently there rather than potential changes.

[egdaniel, 2016-09-02 14:43:23]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-09-02 14:43:23]

The CQ bit was unchecked by egdaniel@google.com

[egdaniel, 2016-09-02 14:43:23]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/2302333002/#ps40001
(title: "update comment")

[egdaniel, 2016-09-02 14:43:24]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-09-02 14:43:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 18:19:20]

Description was changed from

==========
Small perf optimizations preparing sampled images in vulkan

In our current setup, there is no need for storing the sampled images in an
array and then putting in barriers for them later. If we ever change the
system to building up these secondary command buffers early, we will need
to go back to storing the sampled images.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302333002
==========

to

==========
Small perf optimizations preparing sampled images in vulkan

In our current setup, there is no need for storing the sampled images in an
array and then putting in barriers for them later. If we ever change the
system to building up these secondary command buffers early, we will need
to go back to storing the sampled images.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302333002

Committed:
https://skia.googlesource.com/skia/+/8d2141f0dbb36b92d0e3feb23a08663c29b59db0
==========

[commit-bot: I haz the power, 2016-09-02 18:19:21]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8d2141f0dbb36b92d0e3feb23a08663c29b59db0