Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: gpu/command_buffer/service/texture_manager.cc

Issue 2302323002: Reset PIXEL_UNPACK_BUFFER at texture manager initialization time (Closed)
Patch Set: reset at TextureManager::Initialize time Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/test_helper.cc ('k') | gpu/command_buffer/service/texture_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/texture_manager.cc
diff --git a/gpu/command_buffer/service/texture_manager.cc b/gpu/command_buffer/service/texture_manager.cc
index 8899aaee3edf69bcbeb6604863f993b21afe53bc..67615bf25d6a3a39a8ca9772d174c0e343a8954c 100644
--- a/gpu/command_buffer/service/texture_manager.cc
+++ b/gpu/command_buffer/service/texture_manager.cc
@@ -1781,6 +1781,11 @@ TextureManager::TextureManager(MemoryTracker* memory_tracker,
}
bool TextureManager::Initialize() {
+ // Reset PIXEL_UNPACK_BUFFER to avoid unrelated GL error on some GL drivers.
+ if (feature_info_->gl_version_info().is_es3_capable) {
qiankun 2016/09/09 09:52:48 Using this other than feature_info_->IsES3Capable(
Zhenyao Mo 2016/09/09 15:17:08 You can use feature_info_->IsES3Capable() here and
qiankun 2016/09/09 18:16:26 For some test cases, if --enable-unsafe-es3-apis i
+ glBindBuffer(GL_PIXEL_UNPACK_BUFFER, 0);
+ }
+
// TODO(gman): The default textures have to be real textures, not the 0
// texture because we simulate non shared resources on top of shared
// resources and all contexts that share resource share the same default
« no previous file with comments | « gpu/command_buffer/service/test_helper.cc ('k') | gpu/command_buffer/service/texture_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698