Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: gpu/command_buffer/service/texture_manager_unittest.cc

Issue 2302323002: Reset PIXEL_UNPACK_BUFFER at texture manager initialization time (Closed)
Patch Set: reset at TextureManager::Initialize time Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/texture_manager.h" 5 #include "gpu/command_buffer/service/texture_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 void SetUp() override { 82 void SetUp() override {
83 GpuServiceTest::SetUp(); 83 GpuServiceTest::SetUp();
84 manager_.reset(new TextureManager(NULL, 84 manager_.reset(new TextureManager(NULL,
85 feature_info_.get(), 85 feature_info_.get(),
86 kMaxTextureSize, 86 kMaxTextureSize,
87 kMaxCubeMapTextureSize, 87 kMaxCubeMapTextureSize,
88 kMaxRectangleTextureSize, 88 kMaxRectangleTextureSize,
89 kMax3DTextureSize, 89 kMax3DTextureSize,
90 kMaxArrayTextureLayers, 90 kMaxArrayTextureLayers,
91 kUseDefaultTextures)); 91 kUseDefaultTextures));
92 SetupFeatureInfo("", "OpenGL ES 2.0", false);
92 TestHelper::SetupTextureManagerInitExpectations( 93 TestHelper::SetupTextureManagerInitExpectations(
93 gl_.get(), false, false, "", kUseDefaultTextures); 94 gl_.get(), false, false, false, "", kUseDefaultTextures);
94 manager_->Initialize(); 95 manager_->Initialize();
95 error_state_.reset(new ::testing::StrictMock<gles2::MockErrorState>()); 96 error_state_.reset(new ::testing::StrictMock<gles2::MockErrorState>());
96 } 97 }
97 98
98 void TearDown() override { 99 void TearDown() override {
99 manager_->Destroy(false); 100 manager_->Destroy(false);
100 manager_.reset(); 101 manager_.reset();
101 GpuServiceTest::TearDown(); 102 GpuServiceTest::TearDown();
102 } 103 }
103 104
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 SetParameter(texture_ref, GL_TEXTURE_WRAP_T, GL_NEAREST, GL_INVALID_ENUM); 240 SetParameter(texture_ref, GL_TEXTURE_WRAP_T, GL_NEAREST, GL_INVALID_ENUM);
240 EXPECT_EQ(static_cast<GLenum>(GL_CLAMP_TO_EDGE), texture->wrap_t()); 241 EXPECT_EQ(static_cast<GLenum>(GL_CLAMP_TO_EDGE), texture->wrap_t());
241 SetParameter(texture_ref, GL_TEXTURE_MAX_ANISOTROPY_EXT, 0, GL_INVALID_VALUE); 242 SetParameter(texture_ref, GL_TEXTURE_MAX_ANISOTROPY_EXT, 0, GL_INVALID_VALUE);
242 SetParameter(texture_ref, GL_TEXTURE_IMMUTABLE_FORMAT, 0, GL_INVALID_ENUM); 243 SetParameter(texture_ref, GL_TEXTURE_IMMUTABLE_FORMAT, 0, GL_INVALID_ENUM);
243 SetParameter(texture_ref, GL_TEXTURE_IMMUTABLE_LEVELS, 0, GL_INVALID_ENUM); 244 SetParameter(texture_ref, GL_TEXTURE_IMMUTABLE_LEVELS, 0, GL_INVALID_ENUM);
244 } 245 }
245 246
246 TEST_F(TextureManagerTest, UseDefaultTexturesTrue) { 247 TEST_F(TextureManagerTest, UseDefaultTexturesTrue) {
247 bool use_default_textures = true; 248 bool use_default_textures = true;
248 TestHelper::SetupTextureManagerInitExpectations(gl_.get(), 249 TestHelper::SetupTextureManagerInitExpectations(gl_.get(),
249 false, false, "GL_ANGLE_texture_usage", use_default_textures); 250 false, false, false, "GL_ANGLE_texture_usage", use_default_textures);
250 TextureManager manager(NULL, 251 TextureManager manager(NULL,
251 feature_info_.get(), 252 feature_info_.get(),
252 kMaxTextureSize, 253 kMaxTextureSize,
253 kMaxCubeMapTextureSize, 254 kMaxCubeMapTextureSize,
254 kMaxRectangleTextureSize, 255 kMaxRectangleTextureSize,
255 kMax3DTextureSize, 256 kMax3DTextureSize,
256 kMaxArrayTextureLayers, 257 kMaxArrayTextureLayers,
257 use_default_textures); 258 use_default_textures);
258 manager.Initialize(); 259 manager.Initialize();
259 260
260 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_2D) != NULL); 261 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_2D) != NULL);
261 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_CUBE_MAP) != NULL); 262 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_CUBE_MAP) != NULL);
262 263
263 // TODO(vmiura): Test GL_TEXTURE_EXTERNAL_OES & GL_TEXTURE_RECTANGLE_ARB. 264 // TODO(vmiura): Test GL_TEXTURE_EXTERNAL_OES & GL_TEXTURE_RECTANGLE_ARB.
264 265
265 manager.Destroy(false); 266 manager.Destroy(false);
266 } 267 }
267 268
268 TEST_F(TextureManagerTest, UseDefaultTexturesFalse) { 269 TEST_F(TextureManagerTest, UseDefaultTexturesFalse) {
269 bool use_default_textures = false; 270 bool use_default_textures = false;
270 TestHelper::SetupTextureManagerInitExpectations(gl_.get(), 271 TestHelper::SetupTextureManagerInitExpectations(gl_.get(),
271 false, false, "GL_ANGLE_texture_usage", use_default_textures); 272 false, false, false, "GL_ANGLE_texture_usage", use_default_textures);
272 TextureManager manager(NULL, 273 TextureManager manager(NULL,
273 feature_info_.get(), 274 feature_info_.get(),
274 kMaxTextureSize, 275 kMaxTextureSize,
275 kMaxCubeMapTextureSize, 276 kMaxCubeMapTextureSize,
276 kMaxRectangleTextureSize, 277 kMaxRectangleTextureSize,
277 kMax3DTextureSize, 278 kMax3DTextureSize,
278 kMaxArrayTextureLayers, 279 kMaxArrayTextureLayers,
279 use_default_textures); 280 use_default_textures);
280 manager.Initialize(); 281 manager.Initialize();
281 282
282 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_2D) == NULL); 283 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_2D) == NULL);
283 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_CUBE_MAP) == NULL); 284 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_CUBE_MAP) == NULL);
284 285
285 // TODO(vmiura): Test GL_TEXTURE_EXTERNAL_OES & GL_TEXTURE_RECTANGLE_ARB. 286 // TODO(vmiura): Test GL_TEXTURE_EXTERNAL_OES & GL_TEXTURE_RECTANGLE_ARB.
286 287
287 manager.Destroy(false); 288 manager.Destroy(false);
288 } 289 }
289 290
290 TEST_F(TextureManagerTest, UseDefaultTexturesTrueES3) { 291 TEST_F(TextureManagerTest, UseDefaultTexturesTrueES3) {
291 bool use_default_textures = true; 292 bool use_default_textures = true;
292 SetupFeatureInfo("", "OpenGL ES 3.0", true); 293 SetupFeatureInfo("", "OpenGL ES 3.0", true);
293 TestHelper::SetupTextureManagerInitExpectations(gl_.get(), 294 TestHelper::SetupTextureManagerInitExpectations(gl_.get(),
294 true, false, "", use_default_textures); 295 true, true, false, "", use_default_textures);
295 TextureManager manager(NULL, 296 TextureManager manager(NULL,
296 feature_info_.get(), 297 feature_info_.get(),
297 kMaxTextureSize, 298 kMaxTextureSize,
298 kMaxCubeMapTextureSize, 299 kMaxCubeMapTextureSize,
299 kMaxRectangleTextureSize, 300 kMaxRectangleTextureSize,
300 kMax3DTextureSize, 301 kMax3DTextureSize,
301 kMaxArrayTextureLayers, 302 kMaxArrayTextureLayers,
302 use_default_textures); 303 use_default_textures);
303 manager.Initialize(); 304 manager.Initialize();
304 305
305 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_3D) != NULL); 306 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_3D) != NULL);
306 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_2D_ARRAY) != NULL); 307 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_2D_ARRAY) != NULL);
307 308
308 manager.Destroy(false); 309 manager.Destroy(false);
309 } 310 }
310 311
311 TEST_F(TextureManagerTest, UseDefaultTexturesFalseES3) { 312 TEST_F(TextureManagerTest, UseDefaultTexturesFalseES3) {
312 bool use_default_textures = false; 313 bool use_default_textures = false;
313 SetupFeatureInfo("", "OpenGL ES 3.0", true); 314 SetupFeatureInfo("", "OpenGL ES 3.0", true);
314 TestHelper::SetupTextureManagerInitExpectations(gl_.get(), 315 TestHelper::SetupTextureManagerInitExpectations(gl_.get(),
315 true, false, "", use_default_textures); 316 true, true, false, "", use_default_textures);
316 TextureManager manager(NULL, 317 TextureManager manager(NULL,
317 feature_info_.get(), 318 feature_info_.get(),
318 kMaxTextureSize, 319 kMaxTextureSize,
319 kMaxCubeMapTextureSize, 320 kMaxCubeMapTextureSize,
320 kMaxRectangleTextureSize, 321 kMaxRectangleTextureSize,
321 kMax3DTextureSize, 322 kMax3DTextureSize,
322 kMaxArrayTextureLayers, 323 kMaxArrayTextureLayers,
323 use_default_textures); 324 use_default_textures);
324 manager.Initialize(); 325 manager.Initialize();
325 326
326 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_3D) == NULL); 327 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_3D) == NULL);
327 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_2D_ARRAY) == NULL); 328 EXPECT_TRUE(manager.GetDefaultTextureInfo(GL_TEXTURE_2D_ARRAY) == NULL);
328 329
329 manager.Destroy(false); 330 manager.Destroy(false);
330 } 331 }
331 332
332 TEST_F(TextureManagerTest, TextureUsageExt) { 333 TEST_F(TextureManagerTest, TextureUsageExt) {
333 TestHelper::SetupTextureManagerInitExpectations( 334 TestHelper::SetupTextureManagerInitExpectations(
334 gl_.get(), false, false, "GL_ANGLE_texture_usage", kUseDefaultTextures); 335 gl_.get(), false, false, false, "GL_ANGLE_texture_usage",
336 kUseDefaultTextures);
335 TextureManager manager(NULL, 337 TextureManager manager(NULL,
336 feature_info_.get(), 338 feature_info_.get(),
337 kMaxTextureSize, 339 kMaxTextureSize,
338 kMaxCubeMapTextureSize, 340 kMaxCubeMapTextureSize,
339 kMaxRectangleTextureSize, 341 kMaxRectangleTextureSize,
340 kMax3DTextureSize, 342 kMax3DTextureSize,
341 kMaxArrayTextureLayers, 343 kMaxArrayTextureLayers,
342 kUseDefaultTextures); 344 kUseDefaultTextures);
343 manager.Initialize(); 345 manager.Initialize();
344 const GLuint kClient1Id = 1; 346 const GLuint kClient1Id = 1;
345 const GLuint kService1Id = 11; 347 const GLuint kService1Id = 11;
346 // Check we can create texture. 348 // Check we can create texture.
347 manager.CreateTexture(kClient1Id, kService1Id); 349 manager.CreateTexture(kClient1Id, kService1Id);
348 // Check texture got created. 350 // Check texture got created.
349 TextureRef* texture_ref = manager.GetTexture(kClient1Id); 351 TextureRef* texture_ref = manager.GetTexture(kClient1Id);
350 ASSERT_TRUE(texture_ref != NULL); 352 ASSERT_TRUE(texture_ref != NULL);
351 TestHelper::SetTexParameteriWithExpectations( 353 TestHelper::SetTexParameteriWithExpectations(
352 gl_.get(), error_state_.get(), &manager, texture_ref, 354 gl_.get(), error_state_.get(), &manager, texture_ref,
353 GL_TEXTURE_USAGE_ANGLE, GL_FRAMEBUFFER_ATTACHMENT_ANGLE, GL_NO_ERROR); 355 GL_TEXTURE_USAGE_ANGLE, GL_FRAMEBUFFER_ATTACHMENT_ANGLE, GL_NO_ERROR);
354 EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_ATTACHMENT_ANGLE), 356 EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_ATTACHMENT_ANGLE),
355 texture_ref->texture()->usage()); 357 texture_ref->texture()->usage());
356 manager.Destroy(false); 358 manager.Destroy(false);
357 } 359 }
358 360
359 TEST_F(TextureManagerTest, Destroy) { 361 TEST_F(TextureManagerTest, Destroy) {
360 const GLuint kClient1Id = 1; 362 const GLuint kClient1Id = 1;
361 const GLuint kService1Id = 11; 363 const GLuint kService1Id = 11;
362 TestHelper::SetupTextureManagerInitExpectations( 364 TestHelper::SetupTextureManagerInitExpectations(
363 gl_.get(), false, false, "", kUseDefaultTextures); 365 gl_.get(), false, false, false, "", kUseDefaultTextures);
364 TextureManager manager(NULL, 366 TextureManager manager(NULL,
365 feature_info_.get(), 367 feature_info_.get(),
366 kMaxTextureSize, 368 kMaxTextureSize,
367 kMaxCubeMapTextureSize, 369 kMaxCubeMapTextureSize,
368 kMaxRectangleTextureSize, 370 kMaxRectangleTextureSize,
369 kMax3DTextureSize, 371 kMax3DTextureSize,
370 kMaxArrayTextureLayers, 372 kMaxArrayTextureLayers,
371 kUseDefaultTextures); 373 kUseDefaultTextures);
372 manager.Initialize(); 374 manager.Initialize();
373 // Check we can create texture. 375 // Check we can create texture.
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 // Check NPOT height on level 1 539 // Check NPOT height on level 1
538 EXPECT_TRUE(manager.ValidForTarget(GL_TEXTURE_2D, 1, 2, 5, 1)); 540 EXPECT_TRUE(manager.ValidForTarget(GL_TEXTURE_2D, 1, 2, 5, 1));
539 manager.Destroy(false); 541 manager.Destroy(false);
540 } 542 }
541 543
542 TEST_F(TextureManagerTest, AlphaLuminanceCompatibilityProfile) { 544 TEST_F(TextureManagerTest, AlphaLuminanceCompatibilityProfile) {
543 const GLuint kClientId = 1; 545 const GLuint kClientId = 1;
544 const GLuint kServiceId = 11; 546 const GLuint kServiceId = 11;
545 547
546 SetupFeatureInfo("", "2.1", false); 548 SetupFeatureInfo("", "2.1", false);
547 TestHelper::SetupTextureManagerInitExpectations(gl_.get(), false, false, "", 549 TestHelper::SetupTextureManagerInitExpectations(gl_.get(), false, false,
548 kUseDefaultTextures); 550 false, "", kUseDefaultTextures);
549 TextureManager manager(NULL, 551 TextureManager manager(NULL,
550 feature_info_.get(), 552 feature_info_.get(),
551 kMaxTextureSize, 553 kMaxTextureSize,
552 kMaxCubeMapTextureSize, 554 kMaxCubeMapTextureSize,
553 kMaxRectangleTextureSize, 555 kMaxRectangleTextureSize,
554 kMax3DTextureSize, 556 kMax3DTextureSize,
555 kMaxArrayTextureLayers, 557 kMaxArrayTextureLayers,
556 kUseDefaultTextures); 558 kUseDefaultTextures);
557 manager.Initialize(); 559 manager.Initialize();
558 560
(...skipping 23 matching lines...) Expand all
582 .Times(1) 584 .Times(1)
583 .RetiresOnSaturation(); 585 .RetiresOnSaturation();
584 manager.RemoveTexture(kClientId); 586 manager.RemoveTexture(kClientId);
585 } 587 }
586 588
587 TEST_F(TextureManagerTest, AlphaLuminanceCoreProfileEmulation) { 589 TEST_F(TextureManagerTest, AlphaLuminanceCoreProfileEmulation) {
588 const GLuint kClientId = 1; 590 const GLuint kClientId = 1;
589 const GLuint kServiceId = 11; 591 const GLuint kServiceId = 11;
590 592
591 SetupFeatureInfo("", "4.2", true); 593 SetupFeatureInfo("", "4.2", true);
592 TestHelper::SetupTextureManagerInitExpectations(gl_.get(), true, true, "", 594 TestHelper::SetupTextureManagerInitExpectations(gl_.get(), true, true, true,
593 kUseDefaultTextures); 595 "", kUseDefaultTextures);
594 TextureManager manager(NULL, 596 TextureManager manager(NULL,
595 feature_info_.get(), 597 feature_info_.get(),
596 kMaxTextureSize, 598 kMaxTextureSize,
597 kMaxCubeMapTextureSize, 599 kMaxCubeMapTextureSize,
598 kMaxRectangleTextureSize, 600 kMaxRectangleTextureSize,
599 kMax3DTextureSize, 601 kMax3DTextureSize,
600 kMaxArrayTextureLayers, 602 kMaxArrayTextureLayers,
601 kUseDefaultTextures); 603 kUseDefaultTextures);
602 manager.Initialize(); 604 manager.Initialize();
603 605
(...skipping 1641 matching lines...) Expand 10 before | Expand all | Expand 10 after
2245 memory_tracker2_ = new CountingMemoryTracker; 2247 memory_tracker2_ = new CountingMemoryTracker;
2246 texture_manager2_.reset( 2248 texture_manager2_.reset(
2247 new TextureManager(memory_tracker2_.get(), 2249 new TextureManager(memory_tracker2_.get(),
2248 feature_info_.get(), 2250 feature_info_.get(),
2249 TextureManagerTest::kMaxTextureSize, 2251 TextureManagerTest::kMaxTextureSize,
2250 TextureManagerTest::kMaxCubeMapTextureSize, 2252 TextureManagerTest::kMaxCubeMapTextureSize,
2251 TextureManagerTest::kMaxRectangleTextureSize, 2253 TextureManagerTest::kMaxRectangleTextureSize,
2252 TextureManagerTest::kMax3DTextureSize, 2254 TextureManagerTest::kMax3DTextureSize,
2253 TextureManagerTest::kMaxArrayTextureLayers, 2255 TextureManagerTest::kMaxArrayTextureLayers,
2254 kUseDefaultTextures)); 2256 kUseDefaultTextures));
2257 SetupFeatureInfo("", "OpenGL ES 2.0", false);
2255 TestHelper::SetupTextureManagerInitExpectations( 2258 TestHelper::SetupTextureManagerInitExpectations(
2256 gl_.get(), false, false, "", kUseDefaultTextures); 2259 gl_.get(), false, false, false, "", kUseDefaultTextures);
2257 texture_manager1_->Initialize(); 2260 texture_manager1_->Initialize();
2258 TestHelper::SetupTextureManagerInitExpectations( 2261 TestHelper::SetupTextureManagerInitExpectations(
2259 gl_.get(), false, false, "", kUseDefaultTextures); 2262 gl_.get(), false, false, false, "", kUseDefaultTextures);
2260 texture_manager2_->Initialize(); 2263 texture_manager2_->Initialize();
2261 } 2264 }
2262 2265
2263 void TearDown() override { 2266 void TearDown() override {
2264 texture_manager2_->Destroy(false); 2267 texture_manager2_->Destroy(false);
2265 texture_manager2_.reset(); 2268 texture_manager2_.reset();
2266 texture_manager1_->Destroy(false); 2269 texture_manager1_->Destroy(false);
2267 texture_manager1_.reset(); 2270 texture_manager1_.reset();
2268 GpuServiceTest::TearDown(); 2271 GpuServiceTest::TearDown();
2269 } 2272 }
2270 2273
2271 protected: 2274 protected:
2275 void SetupFeatureInfo(const char* gl_extensions,
2276 const char* gl_version,
2277 bool enable_es3) {
2278 TestHelper::SetupFeatureInfoInitExpectationsWithGLVersion(
2279 gl_.get(), gl_extensions, "", gl_version,
2280 feature_info_->context_type(), enable_es3);
2281 feature_info_->InitializeForTesting();
2282 if (enable_es3) {
2283 EXPECT_CALL(*gl_, GetIntegerv(GL_MAX_COLOR_ATTACHMENTS, _))
2284 .WillOnce(SetArgPointee<1>(8))
2285 .RetiresOnSaturation();
2286 EXPECT_CALL(*gl_, GetIntegerv(GL_MAX_DRAW_BUFFERS, _))
2287 .WillOnce(SetArgPointee<1>(8))
2288 .RetiresOnSaturation();
2289 feature_info_->EnableES3Validators();
2290 }
2291 }
2292
2272 scoped_refptr<FeatureInfo> feature_info_; 2293 scoped_refptr<FeatureInfo> feature_info_;
2273 scoped_refptr<CountingMemoryTracker> memory_tracker1_; 2294 scoped_refptr<CountingMemoryTracker> memory_tracker1_;
2274 std::unique_ptr<TextureManager> texture_manager1_; 2295 std::unique_ptr<TextureManager> texture_manager1_;
2275 scoped_refptr<CountingMemoryTracker> memory_tracker2_; 2296 scoped_refptr<CountingMemoryTracker> memory_tracker2_;
2276 std::unique_ptr<TextureManager> texture_manager2_; 2297 std::unique_ptr<TextureManager> texture_manager2_;
2277 }; 2298 };
2278 2299
2279 TEST_F(SharedTextureTest, DeleteTextures) { 2300 TEST_F(SharedTextureTest, DeleteTextures) {
2280 scoped_refptr<TextureRef> ref1 = texture_manager1_->CreateTexture(10, 10); 2301 scoped_refptr<TextureRef> ref1 = texture_manager1_->CreateTexture(10, 10);
2281 scoped_refptr<TextureRef> ref2 = 2302 scoped_refptr<TextureRef> ref2 =
(...skipping 467 matching lines...) Expand 10 before | Expand all | Expand 10 after
2749 ExpectValid( 2770 ExpectValid(
2750 true, GL_DEPTH_STENCIL, GL_UNSIGNED_INT_24_8, GL_DEPTH24_STENCIL8); 2771 true, GL_DEPTH_STENCIL, GL_UNSIGNED_INT_24_8, GL_DEPTH24_STENCIL8);
2751 ExpectValid(true, GL_DEPTH_STENCIL, GL_FLOAT_32_UNSIGNED_INT_24_8_REV, 2772 ExpectValid(true, GL_DEPTH_STENCIL, GL_FLOAT_32_UNSIGNED_INT_24_8_REV,
2752 GL_DEPTH32F_STENCIL8); 2773 GL_DEPTH32F_STENCIL8);
2753 2774
2754 ExpectInvalid(true, GL_RGB_INTEGER, GL_INT, GL_RGBA8); 2775 ExpectInvalid(true, GL_RGB_INTEGER, GL_INT, GL_RGBA8);
2755 } 2776 }
2756 2777
2757 } // namespace gles2 2778 } // namespace gles2
2758 } // namespace gpu 2779 } // namespace gpu
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698