ui/gfx/font_names_testing.cc - Issue 2302313002: Configure font font names in GFX unittests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/font_names_testing.cc

Issue 2302313002: Configure font font names in GFX unittests (Closed)

Patch Set: Use Heiti SC font, namespace, comment, hex escapes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/gfx/font_names_testing.h"

	6

	7 #include "build/build_config.h"

	8

	9 namespace gfx {

	10

	11 #if defined(OS_LINUX)

	12 const char kSymbolFontName[] = "DejaVu Sans";
	jungshik at Google 2016/09/16 19:34:55 Will this test ever be run on an actual Chrome OS Will this test ever be run on an actual Chrome OS device (as opposed to on Linux)? Perhaps, not. Just in case the answer is yes, kSymbolsFontName had better be 'Noto Sans Symbol" on CrOS. Similarly, kCJKFOntName had better be 'Noto Sans CJK JP' (or KR, SC or TC). (I'm planning to remove DejaVu fonts from CrOS). drott 2016/09/20 07:37:39 It would be much better to have access to Noto ind Show quoted text On 2016/09/16 at 19:34:55, jungshik at google wrote: > Will this test ever be run on an actual Chrome OS device (as opposed to on Linux)? Perhaps, not. > > Just in case the answer is yes, kSymbolsFontName had better be 'Noto Sans Symbol" on CrOS. Similarly, kCJKFOntName had better be 'Noto Sans CJK JP' (or KR, SC or TC). > (I'm planning to remove DejaVu fonts from CrOS). It would be much better to have access to Noto indeed, even on Linux. Unfortunately on Linux we still rely on the bot's/system's/Ubuntu's font configuration instead of providing our own set at least for testing. I am not sure whether this test runs on CrOS, probably the bots will tell you once you remove DejaVu Sans - in that case you can extend the ifdef to put the Noto fonts in there.
	13 #else

	14 const char kSymbolFontName[] = "Symbol";

	15 #endif

	16

	17 #if defined(OS_LINUX)

	18 const char kCJKFontName[] = "Kochi Mincho";

	19 #elif defined(OS_MACOSX)

	20 const char kCJKFontName[] = "Heiti SC";

	21 #else

	22 const char kCJKFontName[] = "SimSun";

	23 #endif

	24

	25 } // namespace gfx

OLD	NEW

« no previous file with comments | « ui/gfx/font_names_testing.h ('k') | ui/gfx/font_unittest.cc » ('j') | no next file with comments »