Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 2302233002: Deprecate Chromium Linux32 Goma Canary (clobber) (Closed)

Created:
4 years, 3 months ago by shinyak
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Deprecate Chromium Linux32 Goma Canary (clobber) Now 32bit version chrome is deprecated on Linux, so we don't need to maintain 32bit build. I've asked goma-users ML, and no one said it's necessary. BUG=630938 Committed: https://chromium.googlesource.com/chromium/tools/build/+/b256b2a2404d82c9dec93dbae1993b576cc51397

Patch Set 1 #

Patch Set 2 : Deprecate Chromium Linux32 Goma Canary (clobber) #

Patch Set 3 : Deprecate Chromium Linux32 Goma Canary (clobber) #

Patch Set 4 : Same as Patch Set 1 #

Total comments: 2

Patch Set 5 : Deprecate Chromium Linux32 Goma Canary (clobber) #

Patch Set 6 : Code #

Patch Set 7 : resolve conflict #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -434 lines) Patch
M masters/master.chromium.fyi/master.cfg View 1 2 3 4 3 chunks +0 lines, -9 lines 0 comments Download
M masters/master.chromium.fyi/slaves.cfg View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 2 3 4 5 6 7 1 chunk +0 lines, -15 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux32_Goma_Canary__clobber_.json View 1 2 3 4 5 6 7 1 chunk +0 lines, -402 lines 0 comments Download

Messages

Total messages: 48 (30 generated)
shinyak
4 years, 3 months ago (2016-09-02 04:11:39 UTC) #2
shinyak
oops, removing scripts/slave is not good at this time.
4 years, 3 months ago (2016-09-02 04:13:11 UTC) #3
Yoshisato Yanagisawa
On 2016/09/02 04:13:11, shinyak wrote: > oops, removing scripts/slave is not good at this time. ...
4 years, 3 months ago (2016-09-02 04:15:11 UTC) #4
shinyak
Files in scripts/slave will be removed after master restart
4 years, 3 months ago (2016-09-02 04:15:56 UTC) #5
shinyak
Hmm, presubmit failed. Ah, not good to remove b_chromium_linux32_goma_canary_clobber without removing scripts/slave
4 years, 3 months ago (2016-09-02 04:43:40 UTC) #10
shinyak
hmm... I'll remove all at once.
4 years, 3 months ago (2016-09-02 05:15:26 UTC) #15
tikuta
lgtm
4 years, 3 months ago (2016-09-05 02:40:40 UTC) #20
ukai
https://codereview.chromium.org/2302233002/diff/60001/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://codereview.chromium.org/2302233002/diff/60001/masters/master.chromium.fyi/master.cfg#newcode1238 masters/master.chromium.fyi/master.cfg:1238: b_chromium_linux32_goma_canary_clobber, https://luci-milo.appspot.com/swarming/task/31022acaba348110/steps/presubmit/0/stdout > error while parsing /tmp/kitchen-472623923/build/masters/master.chromium.fyi/master.cfg: > Traceback ...
4 years, 3 months ago (2016-09-05 05:24:20 UTC) #21
shinyak
https://codereview.chromium.org/2302233002/diff/60001/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://codereview.chromium.org/2302233002/diff/60001/masters/master.chromium.fyi/master.cfg#newcode1238 masters/master.chromium.fyi/master.cfg:1238: b_chromium_linux32_goma_canary_clobber, ouch
4 years, 3 months ago (2016-09-05 06:22:27 UTC) #22
ukai
lgtm
4 years, 3 months ago (2016-09-05 07:31:35 UTC) #33
shinyak
hinoka, can you take a look? (or better to assign any other one?)
4 years, 3 months ago (2016-09-08 09:58:06 UTC) #34
hinoka
lgtm
4 years, 3 months ago (2016-09-08 17:10:13 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302233002/120001
4 years, 3 months ago (2016-09-09 04:09:06 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3125f733bb905410)
4 years, 3 months ago (2016-09-09 04:16:16 UTC) #40
shinyak
Hmm, I mistook choosing OWNER :'( dpranke, could you take a look?
4 years, 3 months ago (2016-09-09 04:23:00 UTC) #42
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-09 18:34:29 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302233002/140001
4 years, 3 months ago (2016-09-12 02:23:01 UTC) #46
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 02:26:39 UTC) #48
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/tools/build/+/b256b2a2404d82c9dec9...

Powered by Google App Engine
This is Rietveld 408576698