|
|
Chromium Code Reviews
DescriptionDeprecate Chromium Linux32 Goma Canary (clobber)
Now 32bit version chrome is deprecated on Linux, so we don't need to
maintain 32bit build. I've asked goma-users ML, and no one said
it's necessary.
BUG=630938
Committed: https://chromium.googlesource.com/chromium/tools/build/+/b256b2a2404d82c9dec93dbae1993b576cc51397
Patch Set 1 #Patch Set 2 : Deprecate Chromium Linux32 Goma Canary (clobber) #Patch Set 3 : Deprecate Chromium Linux32 Goma Canary (clobber) #Patch Set 4 : Same as Patch Set 1 #
Total comments: 2
Patch Set 5 : Deprecate Chromium Linux32 Goma Canary (clobber) #Patch Set 6 : Code #Patch Set 7 : resolve conflict #Patch Set 8 : rebase #
Messages
Total messages: 48 (30 generated)
shinyak@chromium.org changed reviewers: + hinoka@chromium.org, tikuta@chromium.org, ukai@chromium.org, yyanagisawa@google.com
oops, removing scripts/slave is not good at this time.
On 2016/09/02 04:13:11, shinyak wrote: > oops, removing scripts/slave is not good at this time. Since this is FYI, and nobody might care broken bot but yeah, we will see breakage of Precise 32 bot in master page. Otherwise, lgtm.
Files in scripts/slave will be removed after master restart
The CQ bit was checked by shinyak@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3101f276a8e7fc10)
Hmm, presubmit failed. Ah, not good to remove b_chromium_linux32_goma_canary_clobber without removing scripts/slave
The CQ bit was checked by shinyak@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/31020bbaa7ea7210)
hmm... I'll remove all at once.
The CQ bit was checked by shinyak@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/31022acaba348110)
lgtm
https://codereview.chromium.org/2302233002/diff/60001/masters/master.chromium... File masters/master.chromium.fyi/master.cfg (right): https://codereview.chromium.org/2302233002/diff/60001/masters/master.chromium... masters/master.chromium.fyi/master.cfg:1238: b_chromium_linux32_goma_canary_clobber, https://luci-milo.appspot.com/swarming/task/31022acaba348110/steps/presubmit/... > error while parsing /tmp/kitchen-472623923/build/masters/master.chromium.fyi/master.cfg: > Traceback (most recent call last): > File "/tmp/kitchen-472623923/build/scripts/slave/../common/master_cfg_utils.py", line 105, in LoadConfig > localdict = ExecuteConfig(canonical_config) > File "/tmp/kitchen-472623923/build/scripts/slave/../common/master_cfg_utils.py", line 80, in ExecuteConfig > exec f in localDict > File "/tmp/kitchen-472623923/build/masters/master.chromium.fyi/master.cfg", line 1238, in <module> > b_chromium_linux32_goma_canary_clobber, > NameError: name 'b_chromium_linux32_goma_canary_clobber' is not defined > > build error encountered! aborting build
https://codereview.chromium.org/2302233002/diff/60001/masters/master.chromium... File masters/master.chromium.fyi/master.cfg (right): https://codereview.chromium.org/2302233002/diff/60001/masters/master.chromium... masters/master.chromium.fyi/master.cfg:1238: b_chromium_linux32_goma_canary_clobber, ouch
The CQ bit was checked by shinyak@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shinyak@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by shinyak@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
hinoka, can you take a look? (or better to assign any other one?)
lgtm
The CQ bit was checked by shinyak@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yyanagisawa@chromium.org, tikuta@chromium.org Link to the patchset: https://codereview.chromium.org/2302233002/#ps120001 (title: "resolve conflict")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3125f733bb905410)
shinyak@chromium.org changed reviewers: + dpranke@chromium.org
Hmm, I mistook choosing OWNER :'( dpranke, could you take a look?
lgtm
The CQ bit was checked by shinyak@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tikuta@chromium.org, yyanagisawa@chromium.org, ukai@chromium.org, hinoka@chromium.org Link to the patchset: https://codereview.chromium.org/2302233002/#ps140001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Deprecate Chromium Linux32 Goma Canary (clobber) Now 32bit version chrome is deprecated on Linux, so we don't need to maintain 32bit build. I've asked goma-users ML, and no one said it's necessary. BUG=630938 ========== to ========== Deprecate Chromium Linux32 Goma Canary (clobber) Now 32bit version chrome is deprecated on Linux, so we don't need to maintain 32bit build. I've asked goma-users ML, and no one said it's necessary. BUG=630938 Committed: https://chromium.googlesource.com/chromium/tools/build/+/b256b2a2404d82c9dec9... ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://chromium.googlesource.com/chromium/tools/build/+/b256b2a2404d82c9dec9... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
