Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2886)

Unified Diff: appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

Issue 2302223002: [Findit] Change the criteria of sending notification to code review. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py b/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
index 935388d3aa0a50e14e489497dad3bea1476224d0..e62debc1be75408cea47a08175a31e4cd7f119e8 100644
--- a/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
+++ b/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
@@ -931,6 +931,22 @@ class IdentifyTryJobCulpritPipelineTest(testing.AppengineTestCase):
self.assertEqual(culprit_map, expected_culprit_map)
self.assertEqual(failed_revisions, ['rev1'])
+ def testReturnNoneIfNoTryJob(self):
+ master_name = 'm'
+ builder_name = 'b'
+ build_number = 8
+
+ try_job = WfTryJob.Create(master_name, builder_name, build_number).put()
+ pipeline = IdentifyTryJobCulpritPipeline()
+ culprit = pipeline.run(master_name, builder_name, build_number, ['rev1'],
+ failure_type.TEST, None, None)
+ self.assertIsNone(culprit)
+
+ try_job = WfTryJob.Get(master_name, builder_name, build_number)
+ self.assertEqual(try_job.test_results, [])
+ self.assertEqual(try_job.status, analysis_status.COMPLETED)
+
+
def testNotifyCulprits(self):
instances = []
class Mocked_SendNotificationForCulpritPipeline(object):
@@ -952,22 +968,10 @@ class IdentifyTryJobCulpritPipelineTest(testing.AppengineTestCase):
'revision': 'r1',
}
}
+ heuristic_cls = [('chromium', 'r1')]
- identify_try_job_culprit_pipeline._NotifyCulprits('m', 'b', 1, culprits)
- self.assertEqual(1, len(instances))
- self.assertTrue(instances[0].started)
-
- def testReturnNoneIfNoTryJob(self):
- master_name = 'm'
- builder_name = 'b'
- build_number = 8
- try_job = WfTryJob.Create(master_name, builder_name, build_number).put()
- pipeline = IdentifyTryJobCulpritPipeline()
- culprit = pipeline.run(master_name, builder_name, build_number, ['rev1'],
- failure_type.TEST, None, None)
- self.assertIsNone(culprit)
-
- try_job = WfTryJob.Get(master_name, builder_name, build_number)
- self.assertEqual(try_job.test_results, [])
- self.assertEqual(try_job.status, analysis_status.COMPLETED)
+ identify_try_job_culprit_pipeline._NotifyCulprits(
+ 'm', 'b', 1, culprits, heuristic_cls)
+ self.assertEqual(1, len(instances))
+ self.assertTrue(instances[0].started)

Powered by Google App Engine
This is Rietveld 408576698