[Findit] Change the criteria of sending notification to code review.

appengine/findit/waterfall/identify_culprit_pipeline.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import logging
 
 from common import time_util
 from common.pipeline_wrapper import BasePipeline
 from model import result_status
 from model import analysis_status
 from model.wf_analysis import WfAnalysis
 from waterfall import build_failure_analysis
+from waterfall.send_notification_for_culprit_pipeline import (
+    SendNotificationForCulpritPipeline)
 
 
 def _GetResultAnalysisStatus(analysis_result):
   """Returns the status of the analysis result.
 
   We can decide the status based on:
     1. whether we found any suspected CL(s).
     2. whether we have triaged the failure.
     3. whether our analysis result is the same as triaged result.
   """
@@ skipping 21 matching lines @@
           'repo_name': suspected_cl['repo_name'],
           'revision': suspected_cl['revision'],
           'commit_position': suspected_cl['commit_position'],
           'url': suspected_cl['url']
       }
       if cl_info not in suspected_cls:
         suspected_cls.append(cl_info)
   return suspected_cls
 
 
+def _GetSuspectedCLFoundByHeuristicForCompile(analysis):
+  """For compile failure, gets the suspected revision found by heuristic."""
+  if not analysis or not analysis.result:
+    return None
+  for failure in analysis.result.get('failures', []):
+    if (failure['step_name'].lower() == 'compile' and
+        len(failure['suspected_cls']) == 1):
+      # Based on confidence calculation, suspected_cl found by heuristic for
+      # compile is very likely to be the culprit.
+      # Since the current confidence calculation is for results with single
+      # suspected_cl, we might need to have the same regulation here.
+      return failure['suspected_cls'][0]
+  return None
+
+
+def _NotifyCompileCulprits(

[lijeffrey, 2016/09/02 06:37:34]

nit: Since this is for compile, shouldn't there only be 1 culprit, thus this
should be named _NotifyCompileCulprit?

[chanli, 2016/09/02 16:57:19]

The changes on identify_culprit_pipeline has been removed

+    master_name, builder_name, build_number, analysis):
+  """Notifies code review if found a culprit for compile failure."""
+  suspect_cl_for_compile =  _GetSuspectedCLFoundByHeuristicForCompile(analysis)
+  if not suspect_cl_for_compile:
+    return
+
+  try:
+    pipeline = SendNotificationForCulpritPipeline(
+        master_name, builder_name, build_number,
+        suspect_cl_for_compile['repo_name'],
+        suspect_cl_for_compile['revision'])
+    pipeline.start()
+  except Exception:  # pragma: no cover.
+    logging.exception(
+        'Failed to notify culprits found by heuristic for compile.')
+
+
 class IdentifyCulpritPipeline(BasePipeline):
   """A pipeline to identify culprit CLs for a build failure."""
 
   # Arguments number differs from overridden method - pylint: disable=W0221
   def run(self, failure_info, change_logs, deps_info, signals, build_completed):
     """Identifies culprit CL.
 
     Args:
       failure_info (dict): Output of pipeline DetectFirstFailurePipeline.
       change_logs (dict): Output of pipeline PullChangelogPipeline.
@@ skipping 11 matching lines @@
         failure_info, change_logs, deps_info, signals)
     analysis = WfAnalysis.Get(master_name, builder_name, build_number)
     analysis.build_completed = build_completed
     analysis.result = analysis_result
     analysis.status = analysis_status.COMPLETED
     analysis.result_status = _GetResultAnalysisStatus(analysis_result)
     analysis.suspected_cls = _GetSuspectedCLs(analysis_result)
     analysis.end_time = time_util.GetUTCNow()
     analysis.put()
 
-    return analysis_result
+    _NotifyCompileCulprits(
+        master_name, builder_name, build_number, analysis)
+
+    return analysis_result