Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1438)

Issue 2302213002: Revert of Fix leaked internal font (Closed)

Created:
4 years, 3 months ago by Wei Li
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Fix leaked internal font (patchset #2 id:60001 of https://codereview.chromium.org/2297303004/ ) Reason for revert: asan bot doesn't like it, will investigate Original issue's description: > Fix leaked internal font > > In CFGAS_FontMgrImp::LoadFont(), a new internal font is created which > is never released. It needs to be correctly marked as internal font to > be released. Fix this by adding a boolean parameter and pass it along > during the creation of the font. > > BUG=pdfium:242 > > Committed: https://pdfium.googlesource.com/pdfium/+/6708106e6a3d54f3370c871ebf6643d1ecf58999 TBR=thestig@chromium.org,dsinclair@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=pdfium:242 Committed: https://pdfium.googlesource.com/pdfium/+/7e4e63b04f87c690b017c43ebbb3218eb30c459a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -41 lines) Patch
M xfa/fgas/font/fgas_gefont.h View 3 chunks +3 lines, -7 lines 0 comments Download
M xfa/fgas/font/fgas_gefont.cpp View 5 chunks +11 lines, -32 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Wei Li
Created Revert of Fix leaked internal font
4 years, 3 months ago (2016-09-02 00:41:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302213002/1
4 years, 3 months ago (2016-09-02 00:42:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/7e4e63b04f87c690b017c43ebbb3218eb30c459a
4 years, 3 months ago (2016-09-02 00:42:15 UTC) #5
Lei Zhang
4 years, 3 months ago (2016-09-02 01:03:00 UTC) #6
Message was sent while issue was closed.
lgtm, bummer.

Powered by Google App Engine
This is Rietveld 408576698