Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Unified Diff: content/browser/web_contents/render_view_host_manager_unittest.cc

Issue 23022006: Remove GetActiveEntry usage from content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing Save Page As code and test. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/render_view_host_manager_unittest.cc
diff --git a/content/browser/web_contents/render_view_host_manager_unittest.cc b/content/browser/web_contents/render_view_host_manager_unittest.cc
index 7d435fac5d6c5eb57747424ddfa010cfaf4532b4..5d56d4e794b77d0ab673b680cc323527d3450602 100644
--- a/content/browser/web_contents/render_view_host_manager_unittest.cc
+++ b/content/browser/web_contents/render_view_host_manager_unittest.cc
@@ -950,7 +950,8 @@ TEST_F(RenderViewHostManagerTest, PageDoesBackAndReload) {
EXPECT_EQ(evil_rvh, contents()->GetRenderManagerForTesting()->current_host());
// Also we should not have a pending navigation entry.
- NavigationEntry* entry = contents()->GetController().GetActiveEntry();
+ EXPECT_TRUE(contents()->GetController().GetPendingEntry() == NULL);
Charlie Reis 2013/09/16 23:10:54 nit: Just use EXPECT_FALSE and we won't need the "
nasko 2013/09/18 17:03:18 I kept it consistent with the surrounding code, wh
Charlie Reis 2013/09/18 18:36:05 Ok. Feel free to send a cleanup CL to me after th
+ NavigationEntry* entry = contents()->GetController().GetVisibleEntry();
ASSERT_TRUE(entry != NULL);
EXPECT_EQ(kUrl2, entry->GetURL());
}

Powered by Google App Engine
This is Rietveld 408576698