content/browser/devtools/devtools_http_handler_impl.cc - Issue 23022006: Remove GetActiveEntry usage from content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_http_handler_impl.cc

Issue 23022006: Remove GetActiveEntry usage from content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing Save Page As code and test. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/devtools_http_handler_impl.cc

diff --git a/content/browser/devtools/devtools_http_handler_impl.cc b/content/browser/devtools/devtools_http_handler_impl.cc

index 8003b8bd75106c5eeb4bf3273afc68b93e8c8d49..ae559f981805fcfe08aa0963590b1c6a0f75f441 100644

--- a/content/browser/devtools/devtools_http_handler_impl.cc

+++ b/content/browser/devtools/devtools_http_handler_impl.cc

@@ -816,7 +816,7 @@ base::DictionaryValue* DevToolsHttpHandlerImpl::SerializePageInfo(

std::string(kThumbUrlPrefix) + id);

NavigationController& controller = web_contents->GetController();

- NavigationEntry* entry = controller.GetActiveEntry();

+ NavigationEntry* entry = controller.GetVisibleEntry();

if (entry != NULL && entry->GetURL().is_valid()) {

dictionary->SetString(kTargetFaviconUrlField,

entry->GetFavicon().url.spec());