content/browser/web_contents/render_view_host_manager_unittest.cc - Issue 23022006: Remove GetActiveEntry usage from content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/render_view_host_manager_unittest.cc

Issue 23022006: Remove GetActiveEntry usage from content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/render_view_host_manager_unittest.cc

diff --git a/content/browser/web_contents/render_view_host_manager_unittest.cc b/content/browser/web_contents/render_view_host_manager_unittest.cc

index ea35e6ba05f5e0931f45df0b4b2e530563d2a2c3..cc15d9a84a673c16ce14df42c1946da35008c40d 100644

--- a/content/browser/web_contents/render_view_host_manager_unittest.cc

+++ b/content/browser/web_contents/render_view_host_manager_unittest.cc

@@ -946,7 +946,7 @@ TEST_F(RenderViewHostManagerTest, PageDoesBackAndReload) {

EXPECT_EQ(evil_rvh, contents()->GetRenderManagerForTesting()->current_host());

// Also we should not have a pending navigation entry.

Charlie Reis 2013/08/16 22:10:14 Can you add a check that GetPendingEntry is null?

nasko 2013/09/12 17:56:31 Done.

- NavigationEntry* entry = contents()->GetController().GetActiveEntry();

+ NavigationEntry* entry = contents()->GetController().GetVisibleEntry();

ASSERT_TRUE(entry != NULL);

EXPECT_EQ(kUrl2, entry->GetURL());

}