Remove GetActiveEntry usage from content.

chrome/browser/download/save_page_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
@@ skipping 575 matching lines @@
 IN_PROC_BROWSER_TEST_F(SavePageBrowserTest,
                        MAYBE_SaveDuringInitialNavigationIncognito) {
   // Open an Incognito window.
   Browser* incognito = CreateIncognitoBrowser();  // Waits.
   ASSERT_TRUE(incognito);
 
   // Create a download item creation waiter on that window.
   DownloadItemCreatedObserver creation_observer(
       BrowserContext::GetDownloadManager(incognito->profile()));
 
+  // The navigation needs to at least commit, otherwise there will be nothing

[Charlie Reis, 2013/09/16 23:10:54]

I agree with rdsmith: this test appears to be a regression test for the case
that Save As is initiated before commit.  We should keep the test that way to
make sure Chrome does something reasonable in that situation.  (Sounds like
you're making progress on this, based on the email thread.)

[nasko, 2013/09/18 17:03:18]

Reverting this in favor of more complete fix as discussed over email.

+  // to save. The test doesn't need to wait for a full page load though.
+  content::WindowedNotificationObserver commit_observer(
+      content::NOTIFICATION_NAV_ENTRY_COMMITTED,
+      content::NotificationService::AllSources());
+
   // Navigate, unblocking with new tab.
   GURL url = URLRequestMockHTTPJob::GetMockUrl(
       base::FilePath(kTestDir).AppendASCII("b.htm"));
   NavigateToURLWithDisposition(incognito, url, NEW_FOREGROUND_TAB,
                                ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB);
+  commit_observer.Wait();
 
   // Save the page before completion.
   base::FilePath full_file_name, dir;
   GetDestinationPaths("b", &full_file_name, &dir);
   scoped_refptr<content::MessageLoopRunner> loop_runner(
       new content::MessageLoopRunner);
   SavePackageFinishedObserver observer(
       content::BrowserContext::GetDownloadManager(incognito->profile()),
       loop_runner->QuitClosure());
   ASSERT_TRUE(GetCurrentTab(incognito)->SavePage(
@@ skipping 197 matching lines @@
       GetDownloadManager())->DownloadPath();
   base::FilePath filename = download_dir.AppendASCII("dataurl.txt");
   ASSERT_TRUE(base::PathExists(filename));
   std::string contents;
   EXPECT_TRUE(base::ReadFileToString(filename, &contents));
   EXPECT_EQ("foo", contents);
 }
 
 }  // namespace