Remove GetActiveEntry usage from content.

content/browser/download/save_package.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/save_package.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/file_util.h"
@@ skipping 237 matching lines @@
   }
 
   STLDeleteValues(&saved_success_items_);
   STLDeleteValues(&in_progress_items_);
   STLDeleteValues(&saved_failed_items_);
 
   file_manager_ = NULL;
 }
 
 GURL SavePackage::GetUrlToBeSaved() {
   // Instead of using web_contents_.GetURL here, we use url() (which is the

[Charlie Reis, 2013/08/16 22:10:14]

Wow, this is confusing on multiple levels.  :)

First, we should clarify the comment to make it clear that they're talking about
the virtual URL (which is the main difference between WebContents::GetURL() and
NavigationEntry::GetURL(), the latter of which is referred to as url()).

Then there's the bigger question of whether they actually wanted this to be the
pending entry or if they really wanted the last committed entry.  Wouldn't they
want the last committed one?  What do they actually save?

(I just tested this and it looks like right click -> Save As seems kind of
broken when there's a slow pending entry.  Seems like a real bug here.)

[nasko, 2013/09/12 17:56:31]

Done.

   // "real" url of the page) from the NavigationEntry because it reflects its
   // origin rather than the displayed one (returned by GetURL) which may be
   // different (like having "view-source:" on the front).
   NavigationEntry* active_entry =
-      web_contents()->GetController().GetActiveEntry();
+      web_contents()->GetController().GetVisibleEntry();
   return active_entry->GetURL();
 }
 
 void SavePackage::Cancel(bool user_action) {
   if (!canceled()) {
     if (user_action)
       user_canceled_ = true;
     else
       disk_error_occurred_ = true;
     Stop();
@@ skipping 1172 matching lines @@
 
 void SavePackage::FinalizeDownloadEntry() {
   DCHECK(download_);
   DCHECK(download_manager_);
 
   download_manager_->OnSavePackageSuccessfullyFinished(download_);
   StopObservation();
 }
 
 }  // namespace content