Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2302173003: Dynamicize some mixin type tests (Closed)

Created:
4 years, 3 months ago by sra1
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Dynamicize some mixin type tests Add dynamic cases to some recent problem tests where dart2js now optimizes away the type tests. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/1201bd552831d38acbe694325993b828c2679e97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M tests/language/mixin_mixin7_test.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M tests/language/mixin_regress_13688_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/regress_18713_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
4 years, 3 months ago (2016-09-02 02:27:08 UTC) #1
Siggi Cherem (dart-lang)
lgtm
4 years, 3 months ago (2016-09-02 16:37:49 UTC) #2
sra1
4 years, 3 months ago (2016-09-02 18:08:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1201bd552831d38acbe694325993b828c2679e97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698