Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2302173002: Update Harmony textfield and combobox default border color. (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, Elly Fong-Jones
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Harmony textfield and combobox default border color. BUG=635160, 635164 Committed: https://crrev.com/f34ffe26c30eb268f62a0240fb442afdebce5d67 Cr-Commit-Position: refs/heads/master@{#416629}

Patch Set 1 #

Patch Set 2 : also tweak checkbox/radio #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M ui/native_theme/common_theme.cc View 3 chunks +12 lines, -8 lines 0 comments Download
M ui/views/controls/button/checkbox.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Evan Stade
4 years, 3 months ago (2016-09-01 22:20:33 UTC) #2
sky
LGTM
4 years, 3 months ago (2016-09-01 23:13:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302173002/20001
4 years, 3 months ago (2016-09-06 15:00:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 15:47:41 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 15:49:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f34ffe26c30eb268f62a0240fb442afdebce5d67
Cr-Commit-Position: refs/heads/master@{#416629}

Powered by Google App Engine
This is Rietveld 408576698