Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2302133002: Add UMA measuring pan scrolling usage. (Closed)

Created:
4 years, 3 months ago by sunyunjia
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA measuring pan scrolling usage. BUG=643167 Committed: https://crrev.com/10f9761b74d51ae9116e16c18fd35bf4713fc819 Cr-Commit-Position: refs/heads/master@{#416991}

Patch Set 1 : Add UMA measuring pan scrolling usage. #

Patch Set 2 : Usecounter and add a test #

Patch Set 3 : Disable the test for linux and mac #

Total comments: 2

Patch Set 4 : Fixed the nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/NeverFixTests View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/panScroll-use-count.html View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/AutoscrollController.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 35 (25 generated)
sunyunjia
PTAL. Thanks!
4 years, 3 months ago (2016-09-02 17:42:44 UTC) #7
bokan
Could we use UseCounter for this? It's easier to test (and we should add a ...
4 years, 3 months ago (2016-09-02 19:05:00 UTC) #8
Ilya Sherman
On 2016/09/02 19:05:00, bokan wrote: > Could we use UseCounter for this? It's easier to ...
4 years, 3 months ago (2016-09-02 21:43:31 UTC) #9
sunyunjia
PTAL, Thanks!
4 years, 3 months ago (2016-09-07 13:07:57 UTC) #22
tdresser
LGTM with nits. https://codereview.chromium.org/2302133002/diff/60001/third_party/WebKit/LayoutTests/fast/events/panScroll-use-count.html File third_party/WebKit/LayoutTests/fast/events/panScroll-use-count.html (right): https://codereview.chromium.org/2302133002/diff/60001/third_party/WebKit/LayoutTests/fast/events/panScroll-use-count.html#newcode13 third_party/WebKit/LayoutTests/fast/events/panScroll-use-count.html:13: For manual testing, hold middle button ...
4 years, 3 months ago (2016-09-07 13:41:03 UTC) #23
bokan
lgtm
4 years, 3 months ago (2016-09-07 14:31:26 UTC) #26
Ilya Sherman
histograms.xml lgtm
4 years, 3 months ago (2016-09-07 17:43:40 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302133002/80001
4 years, 3 months ago (2016-09-07 17:49:50 UTC) #32
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 3 months ago (2016-09-07 17:54:15 UTC) #33
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 17:57:53 UTC) #35
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/10f9761b74d51ae9116e16c18fd35bf4713fc819
Cr-Commit-Position: refs/heads/master@{#416991}

Powered by Google App Engine
This is Rietveld 408576698