Address feedback from "MD Settings: fix infinite setInterval loop"

chrome/browser/resources/settings/settings_page/main_page_behavior.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Calls |readyTest| repeatedly until it returns true, then calls
  * |readyCallback|.
  * @param {function():boolean} readyTest
  * @param {!Function} readyCallback
  */
@@ skipping 41 matching lines @@
    * @param {settings.Route} oldRoute
    */
   currentRouteChanged: function(newRoute, oldRoute) {
     // Allow the page to load before expanding the section. TODO(michaelpg):
     // Time this better when refactoring settings-animated-pages.
     if (!oldRoute && newRoute.isSubpage()) {
       setTimeout(this.tryTransitionToSection_.bind(this));
     } else {
       doWhenReady(
         function() {
-          if (this.scrollHeight > 0)
-            return true;
-
-          // Height is irrelevant if this page isn't the current page.
-          if (!settings.Route[this.route].contains(settings.getCurrentRoute()))
-            return true;
-
-          return false;
+          return this.scrollHeight > 0 ||
+              !settings.Route[this.route].contains(settings.getCurrentRoute());
         }.bind(this),
         this.tryTransitionToSection_.bind(this));
     }
   },
 
   /**
    * If possible, transitions to the current route's section (by expanding or
    * scrolling to it). If another transition is running, finishes or cancels
    * that one, then schedules this function again. This ensures the current
    * section is quickly shown, without getting the page into a broken state --
@@ skipping 230 matching lines @@
       this.scroller.style.width = 'calc(100% - ' + scrollbarWidth + 'px)';
     }
   }
 };
 
 /** @polymerBehavior */
 var MainPageBehavior = [
   settings.RouteObserverBehavior,
   MainPageBehaviorImpl,
 ];