Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4523)

Unified Diff: chrome/common/child_process_logging_posix.cc

Issue 23021021: Set the GPU info using the crash key system instead of platform-specific mechanisms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: '' Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/child_process_logging_posix.cc
diff --git a/chrome/common/child_process_logging_posix.cc b/chrome/common/child_process_logging_posix.cc
index fa1748bd8d480c805818dd3a018bcbadc761742a..c122d6200e72694e2d734a809e2ffc16d56b1b82 100644
--- a/chrome/common/child_process_logging_posix.cc
+++ b/chrome/common/child_process_logging_posix.cc
@@ -12,7 +12,6 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/common/metrics/variations/variations_util.h"
#include "chrome/installer/util/google_update_settings.h"
-#include "gpu/config/gpu_info.h"
#include "url/gurl.h"
Lei Zhang 2013/08/26 21:41:01 I think we forgot to remove this in the last CL.
Robert Sesek 2013/08/27 15:34:52 Done.
namespace child_process_logging {
@@ -28,15 +27,6 @@ char g_client_id[kClientIdSize];
char g_channel[kChannelSize] = "";
-static const size_t kGpuStringSize = 32;
-char g_gpu_vendor_id[kGpuStringSize] = "";
-char g_gpu_device_id[kGpuStringSize] = "";
-char g_gpu_gl_vendor[kGpuStringSize] = "";
-char g_gpu_gl_renderer[kGpuStringSize] = "";
-char g_gpu_driver_ver[kGpuStringSize] = "";
-char g_gpu_ps_ver[kGpuStringSize] = "";
-char g_gpu_vs_ver[kGpuStringSize] = "";
-
char g_printer_info[kPrinterInfoStrLen * kMaxReportedPrinterRecords + 1] = "";
static const size_t kNumSize = 32;
@@ -88,23 +78,6 @@ void SetActiveExtensions(const std::set<std::string>& extension_ids) {
arraysize(g_extension_ids));
}
-void SetGpuInfo(const gpu::GPUInfo& gpu_info) {
- snprintf(g_gpu_vendor_id, arraysize(g_gpu_vendor_id), "0x%04x",
- gpu_info.gpu.vendor_id);
- snprintf(g_gpu_device_id, arraysize(g_gpu_device_id), "0x%04x",
- gpu_info.gpu.device_id);
- base::strlcpy(g_gpu_gl_vendor, gpu_info.gl_vendor.c_str(),
- arraysize(g_gpu_gl_vendor));
- base::strlcpy(g_gpu_gl_renderer, gpu_info.gl_renderer.c_str(),
- arraysize(g_gpu_gl_renderer));
- base::strlcpy(g_gpu_driver_ver, gpu_info.driver_version.c_str(),
- arraysize(g_gpu_driver_ver));
- base::strlcpy(g_gpu_ps_ver, gpu_info.pixel_shader_version.c_str(),
- arraysize(g_gpu_ps_ver));
- base::strlcpy(g_gpu_vs_ver, gpu_info.vertex_shader_version.c_str(),
- arraysize(g_gpu_vs_ver));
-}
-
void SetPrinterInfo(const char* printer_info) {
std::string printer_info_str;
std::vector<std::string> info;

Powered by Google App Engine
This is Rietveld 408576698