src/effects/SkBlurImageFilter.cpp - Issue 23021015: Initial error handling code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkBlurImageFilter.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: 2nd proposition, with some comments adressed Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkBlurImageFilter.cpp

diff --git a/src/effects/SkBlurImageFilter.cpp b/src/effects/SkBlurImageFilter.cpp

index 4b2d3b88ffff8ae3ea7838bbd351b0226682419c..17a2a63e74283707f96b6682cddb2f7e4f390eca 100644

--- a/src/effects/SkBlurImageFilter.cpp

+++ b/src/effects/SkBlurImageFilter.cpp

@@ -19,6 +19,12 @@ SkBlurImageFilter::SkBlurImageFilter(SkFlattenableReadBuffer& buffer)

: INHERITED(buffer) {

fSigma.fWidth = buffer.readScalar();

fSigma.fHeight = buffer.readScalar();

+ if (!SkScalarIsFinite(fSigma.fWidth) ||

+ !SkScalarIsFinite(fSigma.fHeight) ||

+ (fSigma.fWidth < 0) ||

+ (fSigma.fHeight < 0)) {

+ buffer.setError();

+ }

}

SkBlurImageFilter::SkBlurImageFilter(SkScalar sigmaX,