src/core/SkImageFilter.cpp - Issue 23021015: Initial error handling code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkImageFilter.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Simplified SkRect/SkIRect validity tests Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkImageFilter.cpp

diff --git a/src/core/SkImageFilter.cpp b/src/core/SkImageFilter.cpp

index 502613bb68835caf66d4dcb4d893b90b6697a1ad..e180095f787aba81d00fe0e6b7f430bbf875ff98 100644

--- a/src/core/SkImageFilter.cpp

+++ b/src/core/SkImageFilter.cpp

@@ -10,6 +10,7 @@

#include "SkBitmap.h"

#include "SkFlattenableBuffers.h"

#include "SkRect.h"

+#include "SkValidationUtils.h"

#if SK_SUPPORT_GPU

#include "GrContext.h"

#include "GrTexture.h"

@@ -62,6 +63,7 @@ SkImageFilter::SkImageFilter(SkFlattenableReadBuffer& buffer)

}

buffer.readIRect(&fCropRect);

+ buffer.validateData(SkIsValidRect(fCropRect));

Stephen White 2013/09/09 17:43:00 Should we also be validating the number of input S

}

void SkImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const {