src/effects/SkBicubicImageFilter.cpp - Issue 23021015: Initial error handling code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkBicubicImageFilter.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Adding validation helper file Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkBicubicImageFilter.cpp

diff --git a/src/effects/SkBicubicImageFilter.cpp b/src/effects/SkBicubicImageFilter.cpp

index 3b2dd4fe7de4605a0a441fba8cb5ff75d678400d..036626e08b7b233d7f166451bbf77d46116bb6b5 100644

--- a/src/effects/SkBicubicImageFilter.cpp

+++ b/src/effects/SkBicubicImageFilter.cpp

@@ -46,6 +46,10 @@ SkBicubicImageFilter::SkBicubicImageFilter(SkFlattenableReadBuffer& buffer) : IN

SkASSERT(readSize == 16);

fScale.fWidth = buffer.readScalar();

fScale.fHeight = buffer.readScalar();

+ buffer.validateData(SkScalarIsFinite(fScale.fWidth) &&

+ SkScalarIsFinite(fScale.fHeight) &&

+ (fScale.fWidth >= 0) &&

+ (fScale.fHeight >= 0));

}

void SkBicubicImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const {