src/core/SkImageFilter.cpp - Issue 23021015: Initial error handling code - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(105)

My Issues | Starred Open | Closed | All

Unified Diff: src/core/SkImageFilter.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Adding validation helper file Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« include/core/SkRect.h ('K') | « src/core/SkFlattenableSerialization.cpp ('k') | src/core/SkOrderedWriteBuffer.cpp » ('j') | src/core/SkSecureReadBuffer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/core/SkImageFilter.cpp

diff --git a/src/core/SkImageFilter.cpp b/src/core/SkImageFilter.cpp

index 502613bb68835caf66d4dcb4d893b90b6697a1ad..9ef2614a4c9b584a2372ed9d58275d6da3f12d61 100644

--- a/src/core/SkImageFilter.cpp

+++ b/src/core/SkImageFilter.cpp

@@ -62,6 +62,7 @@ SkImageFilter::SkImageFilter(SkFlattenableReadBuffer& buffer)

}

}

buffer.readIRect(&fCropRect);

+ buffer.validateData(fCropRect.isValid());

}

void SkImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const {

« include/core/SkRect.h ('K') | « src/core/SkFlattenableSerialization.cpp ('k') | src/core/SkOrderedWriteBuffer.cpp » ('j') | src/core/SkSecureReadBuffer.h » ('J')

Powered by Google App Engine

This is Rietveld 408576698