src/effects/SkMergeImageFilter.cpp - Issue 23021015: Initial error handling code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkMergeImageFilter.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Added ImageFilter derived classes safety checks (retry) Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkMergeImageFilter.cpp

diff --git a/src/effects/SkMergeImageFilter.cpp b/src/effects/SkMergeImageFilter.cpp

index 0c47c91aff21d73e4da6738682da3d2f7d044657..ff537adeba1127d22f2839c00fd92846f3a46ea6 100755

--- a/src/effects/SkMergeImageFilter.cpp

+++ b/src/effects/SkMergeImageFilter.cpp

@@ -157,8 +157,12 @@ SkMergeImageFilter::SkMergeImageFilter(SkFlattenableReadBuffer& buffer) : INHERI

bool hasModes = buffer.readBool();

if (hasModes) {

this->initAllocModes();

- SkASSERT(buffer.getArrayCount() == countInputs() * sizeof(fModes[0]));

+ int nbInputs = countInputs();

+ SkASSERT(buffer.getArrayCount() == nbInputs * sizeof(fModes[0]));

buffer.readByteArray(fModes);

+ for (int i = 0; i < nbInputs; ++i) {

+ buffer.validateData(SkXfermode::IsValidMode((SkXfermode::Mode)fModes[i]));

+ }

} else {

fModes = 0;

}