src/effects/SkMagnifierImageFilter.cpp - Issue 23021015: Initial error handling code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkMagnifierImageFilter.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Added ImageFilter derived classes safety checks (retry) Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkMagnifierImageFilter.cpp

diff --git a/src/effects/SkMagnifierImageFilter.cpp b/src/effects/SkMagnifierImageFilter.cpp

index 24aef285832b15414f79797aaf012dfd0999f380..41d7698309e5ab512a22c173f14732de248eedff 100644

--- a/src/effects/SkMagnifierImageFilter.cpp

+++ b/src/effects/SkMagnifierImageFilter.cpp

@@ -252,6 +252,8 @@ SkMagnifierImageFilter::SkMagnifierImageFilter(SkFlattenableReadBuffer& buffer)

float height = buffer.readScalar();

fSrcRect = SkRect::MakeXYWH(x, y, width, height);

fInset = buffer.readScalar();

+ buffer.validateData(fSrcRect.isValid() && SkScalarIsFinite(fInset));

}

// FIXME: implement single-input semantics