src/effects/SkColorFilters.cpp - Issue 23021015: Initial error handling code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkColorFilters.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Added ImageFilter derived classes safety checks (retry) Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkColorFilters.cpp

diff --git a/src/effects/SkColorFilters.cpp b/src/effects/SkColorFilters.cpp

index 41a201ef39559fc232e10319c3a9e65f20c39c8c..5fdb4c960a91a056a54d1f1b8c9f7626275606b1 100644

--- a/src/effects/SkColorFilters.cpp

+++ b/src/effects/SkColorFilters.cpp

@@ -98,6 +98,7 @@ protected:

fColor = buffer.readColor();

fMode = (SkXfermode::Mode)buffer.readUInt();

this->updateCache();

+ buffer.validateData(SkXfermode::IsValidMode(fMode));

}

private: