Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: src/effects/SkBlurImageFilter.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: New SkSecureReadBuffer class Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/core/SkWriter32.cpp ('K') | « src/core/SkWriter32.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/effects/SkBlurImageFilter.cpp
diff --git a/src/effects/SkBlurImageFilter.cpp b/src/effects/SkBlurImageFilter.cpp
index 3f97ddd59a362896d18e3083210068b934c42f10..051421df9d027f92c6d006f85ea9b216ec37b711 100644
--- a/src/effects/SkBlurImageFilter.cpp
+++ b/src/effects/SkBlurImageFilter.cpp
@@ -19,6 +19,12 @@ SkBlurImageFilter::SkBlurImageFilter(SkFlattenableReadBuffer& buffer)
: INHERITED(buffer) {
fSigma.fWidth = buffer.readScalar();
fSigma.fHeight = buffer.readScalar();
+ if (!SkScalarIsFinite(fSigma.fWidth) ||
+ !SkScalarIsFinite(fSigma.fHeight) ||
+ (fSigma.fWidth < 0) ||
+ (fSigma.fHeight < 0)) {
+ buffer.setError();
reed1 2013/08/29 19:08:22 Might add a helper for this pattern (now or later)
sugoi1 2013/08/29 19:39:40 Done. Called it validateData() for now.
+ }
}
SkBlurImageFilter::SkBlurImageFilter(SkScalar sigmaX,
« src/core/SkWriter32.cpp ('K') | « src/core/SkWriter32.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698