src/core/SkImageFilter.cpp - Issue 23021015: Initial error handling code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkImageFilter.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: New SkSecureReadBuffer class Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkImageFilter.cpp

diff --git a/src/core/SkImageFilter.cpp b/src/core/SkImageFilter.cpp

index 502613bb68835caf66d4dcb4d893b90b6697a1ad..2aa9bcf2a88c92bde5305fd7254f834cb047017f 100644

--- a/src/core/SkImageFilter.cpp

+++ b/src/core/SkImageFilter.cpp

@@ -62,6 +62,11 @@ SkImageFilter::SkImageFilter(SkFlattenableReadBuffer& buffer)

}

buffer.readIRect(&fCropRect);

+ if ((fCropRect.fLeft > fCropRect.fRight) ||

+ (fCropRect.fTop > fCropRect.fBottom)) {

+ buffer.setError();

+ }

}

void SkImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const {