src/effects/SkColorMatrixFilter.cpp - Issue 23021015: Initial error handling code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkColorMatrixFilter.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Comments fixed Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkColorMatrixFilter.cpp

diff --git a/src/effects/SkColorMatrixFilter.cpp b/src/effects/SkColorMatrixFilter.cpp

index 1e3c779ec661d36e1e8e4aca12acdc769b9555b7..6eb21818d256280536f842c3b2da5dc806e7a673 100644

--- a/src/effects/SkColorMatrixFilter.cpp

+++ b/src/effects/SkColorMatrixFilter.cpp

@@ -310,6 +310,9 @@ SkColorMatrixFilter::SkColorMatrixFilter(SkFlattenableReadBuffer& buffer)

SkASSERT(buffer.getArrayCount() == 20);

buffer.readScalarArray(fMatrix.fMat);

this->initState(fMatrix.fMat);

+ for (int i = 0; i < 20; ++i) {

+ buffer.validate(SkScalarIsFinite(fMatrix.fMat[0]));

mtklein 2013/10/16 18:54:09 fMat[i]?

sugoi1 2013/10/16 20:07:41 ouf... good catch! Fixed

+ }

}

bool SkColorMatrixFilter::asColorMatrix(SkScalar matrix[20]) const {