Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: src/core/SkFlattenable.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Fixing comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/core/SkFlattenable.cpp
diff --git a/src/core/SkFlattenable.cpp b/src/core/SkFlattenable.cpp
index b4efe91004845cb3b00ebfc8b6d3d1131374fce7..b171e04511ef33611c7d78e086c3228a5e12c025 100644
--- a/src/core/SkFlattenable.cpp
+++ b/src/core/SkFlattenable.cpp
@@ -63,64 +63,83 @@ void SkRefCntSet::decPtr(void* ptr) {
///////////////////////////////////////////////////////////////////////////////
///////////////////////////////////////////////////////////////////////////////
-#define MAX_PAIR_COUNT 1024
+#define MAX_ENTRY_COUNT 1024
-struct Pair {
- const char* fName;
- SkFlattenable::Factory fFactory;
+struct Entry {
+ const char* fName;
+ SkFlattenable::Factory fFactory;
+ SkFlattenable::TypeCheck fTypeCheck;
};
static int gCount;
-static Pair gPairs[MAX_PAIR_COUNT];
+static Entry gEntries[MAX_ENTRY_COUNT];
-void SkFlattenable::Register(const char name[], Factory factory) {
+void SkFlattenable::Register(const char name[], Factory factory, TypeCheck typeCheck) {
SkASSERT(name);
SkASSERT(factory);
+ SkASSERT(typeCheck);
- static bool gOnce;
+ static bool gOnce = false;
if (!gOnce) {
gCount = 0;
gOnce = true;
}
- SkASSERT(gCount < MAX_PAIR_COUNT);
+ SkASSERT(gCount < MAX_ENTRY_COUNT);
- gPairs[gCount].fName = name;
- gPairs[gCount].fFactory = factory;
+ gEntries[gCount].fName = name;
+ gEntries[gCount].fFactory = factory;
+ gEntries[gCount].fTypeCheck = typeCheck;
gCount += 1;
}
#ifdef SK_DEBUG
static void report_no_entries(const char* functionName) {
if (!gCount) {
- SkDebugf("%s has no registered name/factory pairs."
- " Call SkGraphics::Init() at process initialization time.",
+ SkDebugf("%s has no registered name/factory/type entries."
+ " Call SkFlattenable::InitializeFlattenablesIfNeeded() before using gEntries",
functionName);
}
}
#endif
SkFlattenable::Factory SkFlattenable::NameToFactory(const char name[]) {
+ InitializeFlattenablesIfNeeded();
#ifdef SK_DEBUG
report_no_entries(__FUNCTION__);
#endif
- const Pair* pairs = gPairs;
+ const Entry* entries = gEntries;
for (int i = gCount - 1; i >= 0; --i) {
- if (strcmp(pairs[i].fName, name) == 0) {
- return pairs[i].fFactory;
+ if (strcmp(entries[i].fName, name) == 0) {
+ return entries[i].fFactory;
+ }
+ }
+ return NULL;
+}
+
+SkFlattenable::TypeCheck SkFlattenable::NameToTypeCheck(const char name[]) {
+ InitializeFlattenablesIfNeeded();
+#ifdef SK_DEBUG
+ report_no_entries(__FUNCTION__);
+#endif
+ const Entry* entries = gEntries;
+ for (int i = gCount - 1; i >= 0; --i) {
+ if (strcmp(entries[i].fName, name) == 0) {
+ return entries[i].fTypeCheck;
}
}
return NULL;
}
const char* SkFlattenable::FactoryToName(Factory fact) {
+ InitializeFlattenablesIfNeeded();
#ifdef SK_DEBUG
report_no_entries(__FUNCTION__);
#endif
- const Pair* pairs = gPairs;
+ const Entry* entries = gEntries;
for (int i = gCount - 1; i >= 0; --i) {
- if (pairs[i].fFactory == fact) {
- return pairs[i].fName;
+ if (entries[i].fFactory == fact) {
+ return entries[i].fName;
}
}
return NULL;

Powered by Google App Engine
This is Rietveld 408576698