src/effects/SkTileImageFilter.cpp - Issue 23021015: Initial error handling code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkTileImageFilter.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Serialization with strings as ID Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkTileImageFilter.cpp

diff --git a/src/effects/SkTileImageFilter.cpp b/src/effects/SkTileImageFilter.cpp

index a7374ade0c6a0c743d148cec1e575b04e0d9a93f..8cc096cf370043b4ecbd813bb171305cef43126f 100644

--- a/src/effects/SkTileImageFilter.cpp

+++ b/src/effects/SkTileImageFilter.cpp

@@ -13,6 +13,7 @@

#include "SkMatrix.h"

#include "SkPaint.h"

#include "SkShader.h"

+#include "SkValidationUtils.h"

bool SkTileImageFilter::onFilterImage(Proxy* proxy, const SkBitmap& src, const SkMatrix& ctm,

SkBitmap* dst, SkIPoint* offset) {

@@ -56,6 +57,7 @@ bool SkTileImageFilter::onFilterImage(Proxy* proxy, const SkBitmap& src, const S

SkTileImageFilter::SkTileImageFilter(SkFlattenableReadBuffer& buffer) : INHERITED(buffer) {

buffer.readRect(&fSrcRect);

buffer.readRect(&fDstRect);

+ buffer.validate(SkIsValidRect(fSrcRect) && SkIsValidRect(fDstRect));

}

void SkTileImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const {