src/effects/SkColorFilters.cpp - Issue 23021015: Initial error handling code - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(101)

My Issues | Starred Open | Closed | All

Unified Diff: src/effects/SkColorFilters.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Serialization with strings as ID Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« src/core/SkValidatingReadBuffer.cpp ('K') | « src/effects/SkBlurImageFilter.cpp ('k') | src/effects/SkColorMatrixFilter.cpp » ('j') | src/ports/SkGlobalInitialization_chromium.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/effects/SkColorFilters.cpp

diff --git a/src/effects/SkColorFilters.cpp b/src/effects/SkColorFilters.cpp

index 41a201ef39559fc232e10319c3a9e65f20c39c8c..7373f004d53d3b43c8ae2853298af3cebb46a8e1 100644

--- a/src/effects/SkColorFilters.cpp

+++ b/src/effects/SkColorFilters.cpp

@@ -13,6 +13,7 @@

#include "SkFlattenableBuffers.h"

#include "SkUtils.h"

#include "SkString.h"

+#include "SkValidationUtils.h"

#define ILLEGAL_XFERMODE_MODE ((SkXfermode::Mode)-1)

@@ -98,6 +99,7 @@ protected:

fColor = buffer.readColor();

fMode = (SkXfermode::Mode)buffer.readUInt();

this->updateCache();

+ buffer.validate(SkIsValidMode(fMode));

}

private:

« src/core/SkValidatingReadBuffer.cpp ('K') | « src/effects/SkBlurImageFilter.cpp ('k') | src/effects/SkColorMatrixFilter.cpp » ('j') | src/ports/SkGlobalInitialization_chromium.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698