src/core/SkFlattenableBuffers.cpp - Issue 23021015: Initial error handling code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkFlattenableBuffers.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Serialization with strings as ID Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkFlattenableBuffers.cpp

diff --git a/src/core/SkFlattenableBuffers.cpp b/src/core/SkFlattenableBuffers.cpp

index 50a47d5c47c209857f468fae86a575f0bd7c8de2..72cd492cd8e5425506ce532faffba098b326d179 100644

--- a/src/core/SkFlattenableBuffers.cpp

+++ b/src/core/SkFlattenableBuffers.cpp

@@ -9,7 +9,8 @@

#include "SkPaint.h"

#include "SkTypeface.h"

-SkFlattenableReadBuffer::SkFlattenableReadBuffer() {

+SkFlattenableReadBuffer::SkFlattenableReadBuffer() :

+ fError(false) {

mtklein 2013/10/07 19:29:56 This is what makes me think fError doesn't really

// Set default values. These should be explicitly set by our client

// via setFlags() if the buffer came from serialization.

fFlags = 0;