src/core/SkOrderedReadBuffer.cpp - Issue 23021015: Initial error handling code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkOrderedReadBuffer.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Minor comment fixes Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkOrderedReadBuffer.cpp

diff --git a/src/core/SkOrderedReadBuffer.cpp b/src/core/SkOrderedReadBuffer.cpp

index 9d991949084e5b9586d57baeaadf72363eb3e3ef..94a086a60dd3ec93787d7efb55c9461c7731a679 100644

--- a/src/core/SkOrderedReadBuffer.cpp

+++ b/src/core/SkOrderedReadBuffer.cpp

@@ -268,7 +268,9 @@ SkTypeface* SkOrderedReadBuffer::readTypeface() {

}

-SkFlattenable* SkOrderedReadBuffer::readFlattenable() {

+// We ignore this SkFlattenable::Type parameter here because we're assuming the data

+// in the SkOrderedReadBuffer is trusted and we don't need to do type checking

+SkFlattenable* SkOrderedReadBuffer::readFlattenable(SkFlattenable::Type) {

SkFlattenable::Factory factory = NULL;

if (fFactoryCount > 0) {