Initial error handling code

src/effects/SkArithmeticMode.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkArithmeticMode.h"
 #include "SkColorPriv.h"
 #include "SkFlattenableBuffers.h"
@@ skipping 213 matching lines @@
         }
         if (0 == i3) {
             return SkNEW_ARGS(SkArithmeticMode_src, (i2, i4));
         }
         return SkNEW_ARGS(SkArithmeticMode_linear, (i2, i3, i4));
 #endif
     }
     return SkNEW_ARGS(SkArithmeticMode_scalar, (k1, k2, k3, k4));
 }
 
+SkFlattenable::Factory SkArithmeticMode::GetFactory(SkFlattenable::Type type) {
+    switch(type) {

[mtklein, 2013/09/24 22:52:18]

For these small guys, I think you're going to be leaving folks scratching their
heads why you didn't write

if (SkFlattenable::kSkArithmeticMode_scalar == type) {
  return SkArithmeticMode_scalar::CreateProc;
}
return NULL;

Similar below and I'm guessing on many files to come.

[sugoi1, 2013/09/25 21:15:27]

Done.

+    case SkFlattenable::kSkArithmeticMode_scalar:
+        return SkArithmeticMode_scalar::CreateProc;
+    default:
+        break;
+    }
+    return NULL;
+}
+
+SkFlattenable::TypeCheck SkArithmeticMode::GetTypeCheck(SkFlattenable::Type type) {
+    switch(type) {
+    case SkFlattenable::kSkArithmeticMode_scalar:
+        return SkArithmeticMode_scalar::IsA;
+    default:
+        break;
+    }
+    return NULL;
+}
 
 //////////////////////////////////////////////////////////////////////////////
 
 #if SK_SUPPORT_GPU
 
 class GrGLArithmeticEffect : public GrGLEffect {
 public:
     GrGLArithmeticEffect(const GrBackendEffectFactory&, const GrDrawEffect&);
     virtual ~GrGLArithmeticEffect();
 
@@ skipping 199 matching lines @@
                                              background);
     }
     return true;
 }
 
 #endif
 
 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_START(SkArithmeticMode)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkArithmeticMode_scalar)
 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_END