Initial error handling code

include/core/SkColorFilter.h

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkColorFilter_DEFINED
 #define SkColorFilter_DEFINED
 
 #include "SkColor.h"
 #include "SkFlattenable.h"
 #include "SkXfermode.h"
 
 class SkBitmap;
 class GrEffectRef;
 class GrContext;
 
 class SK_API SkColorFilter : public SkFlattenable {
+    typedef SkFlattenable INHERITED;
 public:
     SK_DECLARE_INST_COUNT(SkColorFilter)
 
     /**
      *  If the filter can be represented by a source color plus Mode, this
      *  returns true, and sets (if not NULL) the color and mode appropriately.
      *  If not, this returns false and ignores the parameters.
      */
     virtual bool asColorMode(SkColor* color, SkXfermode::Mode* mode) const;
 
@@ skipping 83 matching lines @@
     */
     static SkColorFilter* CreateLightingFilter(SkColor mul, SkColor add);
 
     /** A subclass may implement this factory function to work with the GPU backend. If the return
         is non-NULL then the caller owns a ref on the returned object.
      */
     virtual GrEffectRef* asNewEffect(GrContext*) const;
 
     SkDEVCODE(virtual void toString(SkString* str) const = 0;)
 
     SK_DECLARE_FLATTENABLE_REGISTRAR_GROUP()

[mtklein, 2013/09/24 22:52:18]

I think we're going to have to work on some of these names.  I know that they
all have something to do with flattening / serialization, but I've got no clue
exactly what each means without looking it up in the header.

[sugoi1, 2013/09/25 21:15:27]

You're right.

SK_DEFINE_FLATTENABLE_TYPE defines all the type related functions like GetType()
and IsA(), so this is all "type checking" related.

SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_UTILS could easily have a better
name. It declares static accessor functions required by every SkFlattenable
derived class that doesn't expose them through their public APIs. Currently, it
declares functions to return function pointers to the "factory" and the "type
checking" functions of each class. Again, this is only necessary if these aren't
accessible in the public section of a class in a header file.

+    SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_UTILS()
+    SK_DEFINE_FLATTENABLE_TYPE(SkColorFilter)
 protected:
     SkColorFilter() {}
     SkColorFilter(SkFlattenableReadBuffer& rb) : INHERITED(rb) {}
-
-private:
-    typedef SkFlattenable INHERITED;
 };
 
 #endif