Initial error handling code

src/core/SkImageFilter.cpp

 /*
  * Copyright 2012 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkImageFilter.h"
 
 #include "SkBitmap.h"
@@ skipping 44 matching lines @@
 SkImageFilter::SkImageFilter(SkFlattenableReadBuffer& buffer)
     : fInputCount(buffer.readInt()), fInputs(new SkImageFilter*[fInputCount]) {
     for (int i = 0; i < fInputCount; i++) {
         if (buffer.readBool()) {
             fInputs[i] = static_cast<SkImageFilter*>(buffer.readFlattenable());
         } else {
             fInputs[i] = NULL;
         }
     }
     buffer.readIRect(&fCropRect);
+        
+    if (!SkScalarIsFinite(fCropRect.fLeft) ||

[reed1, 2013/08/22 15:41:14]

SkIRect stores ints, so calling isfinite does not make sense.

[sugoi1, 2013/08/22 17:37:02]

Oops, fixed.

+        !SkScalarIsFinite(fCropRect.fRight) ||
+        !SkScalarIsFinite(fCropRect.fTop) ||
+        !SkScalarIsFinite(fCropRect.fBottom) ||
+        (fCropRect.fLeft > fCropRect.fRight) ||
+        (fCropRect.fTop > fCropRect.fBottom)) {

[sugoi, 2013/08/21 20:19:39]

Although it's counter intuitive, "top" really has to be smaller than "bottom".

[scroggo, 2013/08/21 23:56:00]

Depends on which way you think the y-axis should go :)

+        buffer.setError();
+    }
 }
 
 void SkImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const {
     buffer.writeInt(fInputCount);
     for (int i = 0; i < fInputCount; i++) {
         SkImageFilter* input = getInput(i);
         buffer.writeBool(input != NULL);
         if (input != NULL) {
             buffer.writeFlattenable(input);
         }
@@ skipping 87 matching lines @@
     return true;
 }
 
 bool SkImageFilter::asNewEffect(GrEffectRef**, GrTexture*, const SkIPoint& offset) const {
     return false;
 }
 
 bool SkImageFilter::asColorFilter(SkColorFilter**) const {
     return false;
 }