Initial error handling code

src/core/SkImageFilter.cpp

 /*
  * Copyright 2012 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkImageFilter.h"
 
 #include "SkBitmap.h"
 #include "SkFlattenableBuffers.h"
 #include "SkRect.h"
+#include "SkValidationUtils.h"
 #if SK_SUPPORT_GPU
 #include "GrContext.h"
 #include "GrTexture.h"
 #include "SkImageFilterUtils.h"
 #endif
 
 SK_DEFINE_INST_COUNT(SkImageFilter)
 
 SkImageFilter::SkImageFilter(int inputCount, SkImageFilter** inputs, const CropRect* cropRect)
   : fInputCount(inputCount),
@@ skipping 35 matching lines @@
         if (buffer.readBool()) {
             fInputs[i] = buffer.readImageFilter();
         } else {
             fInputs[i] = NULL;
         }
     }
     SkRect rect;
     buffer.readRect(&rect);
     uint32_t flags = buffer.readUInt();
     fCropRect = CropRect(rect, flags);
+    // Do not use SkIsValidRect() here, since width() and height() are allowed
+    // to be larger than SK_MaxS32 in this specific case. Check inversion instead.

[Stephen White, 2013/10/16 20:27:24]

Actually, this should no longer be the case. The "unspecified" state has been
pulled out into the fFlags, so you should be able to use SkIsValidRect() on the
rect now.

[sugoi1, 2013/10/17 15:20:39]

Done.

+    buffer.validate(!rect.isInverted());
 }
 
 void SkImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const {
     buffer.writeInt(fInputCount);
     for (int i = 0; i < fInputCount; i++) {
         SkImageFilter* input = getInput(i);
         buffer.writeBool(input != NULL);
         if (input != NULL) {
             buffer.writeFlattenable(input);
         }
@@ skipping 100 matching lines @@
     return true;
 }
 
 bool SkImageFilter::asNewEffect(GrEffectRef**, GrTexture*, const SkMatrix&) const {
     return false;
 }
 
 bool SkImageFilter::asColorFilter(SkColorFilter**) const {
     return false;
 }