Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2302073002: Fix some corpus test images (Closed)

Created:
4 years, 3 months ago by npm
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some corpus test images Side-by-side shows that they were not being rendered properly. This will be the result when Issue 2297313002 lands R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium_tests/+/33cc137ca7d8ce328f7f1c1a7cfacc2ba08ba5ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M fx/FRC_8.2.4_part1/FRC_10_8.2.4__remove_ModDate_value_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_11_8.2.4__remove_ModDate_all_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_12_8.2.4__remove_ModDate_obj__expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_13_8.2.4_remove_Size_value_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_14_8.2.4_remove_Size_all_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_15_8.2.4_remove_Size_obj_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_16_8.2.4__remove_CompressedSize__value_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_17_8.2.4__remove_CompressedSize__all_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_18_8.2.4__remove_CompressedSize__obj_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_19_8.2.4__remove_CreationDate_value_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_1_8.2.4__original_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_20_8.2.4__remove_CreationDate_all_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_21_8.2.4__remove_CreationDate_obj_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_22_8.2.4__remove_Order_value_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_23_8.2.4__remove_Order_all_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_24_8.2.4__remove_Order_obj_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_2_8.2.4__add_type__expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_3_8.2.4__add_type_value_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_4_8.2.4__remove_FileName_value_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_5_8.2.4__remove_FileName_all_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_6_8.2.4__remove_FileName_obj_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_7_8.2.4__remove_Description_value_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_8_8.2.4__remove__Description_all_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.2.4_part1/FRC_9_8.2.4__remove__Description_obj_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 7 (3 generated)
npm
PTAL
4 years, 3 months ago (2016-09-01 17:53:56 UTC) #3
dsinclair
lgtm
4 years, 3 months ago (2016-09-01 18:01:08 UTC) #4
Lei Zhang
looks better to me!
4 years, 3 months ago (2016-09-01 18:46:19 UTC) #5
npm
4 years, 3 months ago (2016-09-01 19:13:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
33cc137ca7d8ce328f7f1c1a7cfacc2ba08ba5ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698